Re: dovecot 2.3.11.3 - vfprintf messages

[Mark Patruck]

On 2020-08-13 14:15, Stuart Henderson wrote:

On 2020/08/13 12:51, Mark Patruck wrote:

Anyone else seeing these lines filling up /var/log/messages after updating
to dovecot 2.3.11.3

lmtp: vfprintf %s NULL in "Cache %s: "

Ah, yes I am.

I've reported it here:
https://dovecot.org/pipermail/dovecot/2020-August/119645.html

Thanks. I'm running with the patch and no more vfprintf messages.

mail/dovecot diff attached.


--
Mark Patruck ( mark at wrapped.cx )
GPG key 0xF2865E51 / 187F F6D3 EE04 1DCE 1C74  F644 0D3C F66F F286 5E51

https://www.wrapped.cx

Index: Makefile
===================================================================
RCS file: /cvs/ports/mail/dovecot/Makefile,v
retrieving revision 1.290
diff -u -p -r1.290 Makefile
--- Makefile    12 Aug 2020 15:21:11 -0000      1.290
+++ Makefile    13 Aug 2020 15:23:31 -0000
@@ -8,6 +8,7 @@ COMMENT-postgresql= PostgreSQL authentic
 V_MAJOR=       2.3
 V_DOVECOT=     2.3.11.3
 EPOCH=         0
+REVISION-server=0
 
 DISTNAME=      dovecot-${V_DOVECOT}
 PKGNAME=       dovecot-${V_DOVECOT}
Index: patches/patch-src_lib-index_mail-cache_c
===================================================================
RCS file: patches/patch-src_lib-index_mail-cache_c
diff -N patches/patch-src_lib-index_mail-cache_c
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_lib-index_mail-cache_c    13 Aug 2020 15:23:31 -0000
@@ -0,0 +1,26 @@
+$OpenBSD$
+
+lib-index: Fix cache event's log prefix for in-memory indexes, see:
+
+https://dovecot.org/pipermail/dovecot/2020-August/119647.html
+
+
+Index: src/lib-index/mail-cache.c
+--- src/lib-index/mail-cache.c.orig
++++ src/lib-index/mail-cache.c
+@@ -569,8 +569,13 @@ mail_cache_open_or_create_path(struct mail_index *inde
+ 
+       cache->event = event_create(index->event);
+       event_add_category(cache->event, &event_category_mail_cache);
+-      event_set_append_log_prefix(cache->event,
+-              t_strdup_printf("Cache %s: ", cache->filepath));
++      if (cache->filepath != NULL) {
++              event_set_append_log_prefix(cache->event,
++                      t_strdup_printf("Cache %s: ", cache->filepath));
++      } else {
++              event_set_append_log_prefix(cache->event,
++                                          "Cache (in-memory index): ");
++      }
+ 
+       cache->dotlock_settings.use_excl_lock =
+               (index->flags & MAIL_INDEX_OPEN_FLAG_DOTLOCK_USE_EXCL) != 0;