Here is the revised patch:
   i) Move up FIX_EXTRACT_PERMISSIONS and PKG_ARCH.
   ii) Add p5-Moo and p5-Mouse as TEST_DEPENDS.

wen

________________________________
发件人: Andrew Hewus Fresh <and...@afresh1.com>
发送时间: 2020年7月29日 12:09
收件人: wen heping <wenheping2...@hotmail.com>
抄送: ports@openbsd.org <ports@openbsd.org>
主题: Re: [NEW] devel/p5-Test-CleanNamespaces

On Sat, Jul 25, 2020 at 02:09:29AM +0000, wen heping wrote:
> Hi, ports@:
>
>    Here is a patch to create new port p5-Test-CleanNamespaces,
> it is required by the future update of p5-Moose.
>    It builds well and all tests pass.


FIX_EXTRACT_PERMISSIONS (and optionally PKG_ARCH) should move up by the
DISTNAME to be easier to remember to double-check when updating.

We could add a few devel/p5-Moo and devel/p5-Mouse to TEST_DEPENDS to
avoid sometimes skipping those tests.

# Additional DEPENDS to avoid skipping test
MAKE_ENV +=     AUTOMATED_TESTING=1
TEST_DEPENDS += devel/p5-Moo \
                devel/p5-Moose \
                devel/p5-MooseX-Role-Parameterized \
                devel/p5-Mouse

The Moose* and AUTOMATED_TESTING could go either way, but I think Moo
and Mouse are important.

With that minor cleanup, OK afresh1@

l8rZ,
--
andrew - http://afresh1.com

Software doesn't do what you want it to do, it does what you tell it do.
                      -- Stefan G. Weichinger.

Attachment: p5-Test-CleanNamespaces-p0.tar.gz
Description: p5-Test-CleanNamespaces-p0.tar.gz

Reply via email to