Hi Peter -- On Tuesday, July 28, 2020 2:12 PM, Peter Ezetta <protoca...@gmail.com> wrote:
> Hi ports@, > > Attached is a new port of md4c-0.4.4, a Markdown parsing library for C > https://github.com/mity/md4c. > > Patch to fix the tests has been submitted upstream. > > Builds and tests fine on amd64. > > OK? Comments? > > Thanks, > Peter Thanks for the port. Attached is a tweaked version with the following: * Tweaked COMMENT to "markdown parsing library for C" which to me is more understandable than "c markdown parser." * Removed DISTNAME. The GH_* variables take care of it. And when you have something appear twice (like 0.4.4 in this case), it is a good candidate to turn into a variable. But we need not do that now by letting the GH_* variables take care of things. * Likewise, the GH_* variables take care of HOMEPAGE for you too. * When I tried to build this on sparc64, it did not build because md4c uses __builtin_unreachable, which is not available on gcc-4.2.1. Switching to COMPILERS=base-clang ports-gcc and COMPILER_LANGS=c lets it build successfully on sparc64. * Less whitespace in pkg/DESCR. It was on the order of 35 lines. I got it down to 25. That still seems like too much but it is better. All tests pass on amd64 and sparc64. In the future, can you please tar up the directory rather than the individual files? I was not expecting your tarball to dump all of its contents into my current working directory. ~Brian
md4c.tgz
Description: application/compressed-tar
