On Sat, 25 Jul 2020, Kurt Mosiejczuk wrote: > Update py-humanize to 2.5.0. It drops python2 support, but the only > consumer is tootstream which is python3. > > All tests pass on amd64 and tootstream, the only consumer, still functions > properly.
All tests pass for me too. But, I could not make them run (before or after your patch) because it was trying to install some modules. I think this is not related to py-humanize, but to devel/py-freezegun. I'm testing this now and I'll probably update it. > ok? One comment inline, a part of that ok paco. > --Kurt > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/textproc/py-humanize/Makefile,v > retrieving revision 1.6 > diff -u -p -r1.6 Makefile > --- Makefile 3 Jul 2020 21:13:14 -0000 1.6 > +++ Makefile 25 Jul 2020 21:33:57 -0000 > @@ -2,10 +2,9 @@ > > COMMENT = python number humanization utilities > > -MODPY_EGG_VERSION = 1.0.0 > +MODPY_EGG_VERSION = 2.5.0 > DISTNAME = humanize-${MODPY_EGG_VERSION} > PKGNAME = py-humanize-${MODPY_EGG_VERSION} > -REVISION = 0 > > CATEGORIES = textproc > > @@ -22,15 +21,11 @@ MODPY_PI = Yes > MODPY_PYTEST = Yes > > FLAVORS = python3 > -FLAVOR ?= > +FLAVOR = python3 > > BUILD_DEPENDS = devel/py-setuptools_scm${MODPY_FLAVOR} > TEST_DEPENDS = devel/py-freezegun${MODPY_FLAVOR} > > TEST_ENV = PYTHONPATH=${WRKSRC}/src > - > -.if !${FLAVOR:Mpython3} > -TEST_DEPENDS += devel/py-mock > -.endif > > .include <bsd.port.mk> > Index: distinfo > =================================================================== > RCS file: /cvs/ports/textproc/py-humanize/distinfo,v > retrieving revision 1.2 > diff -u -p -r1.2 distinfo > --- distinfo 10 Feb 2020 14:44:54 -0000 1.2 > +++ distinfo 25 Jul 2020 21:33:57 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (humanize-1.0.0.tar.gz) = OKzptmvK63+Bhrnb8LNEjgAUjltPuvcm+Wx4nlLD50E= > -SIZE (humanize-1.0.0.tar.gz) = 34411 > +SHA256 (humanize-2.5.0.tar.gz) = imi9m8y4mf2b+x5tlsHoTkR1VRzJpbW9vWm5sc/RnIA= > +SIZE (humanize-2.5.0.tar.gz) = 48126 > Index: pkg/PLIST > =================================================================== > RCS file: /cvs/ports/textproc/py-humanize/pkg/PLIST,v > retrieving revision 1.2 > diff -u -p -r1.2 PLIST > --- pkg/PLIST 10 Feb 2020 14:44:54 -0000 1.2 > +++ pkg/PLIST 25 Jul 2020 21:33:57 -0000 > @@ -1,4 +1,5 @@ > @comment $OpenBSD: PLIST,v 1.2 2020/02/10 14:44:54 kmos Exp $ > +@pkgpath textproc/py-humanize Shouldn't we add the @conflict line too ? Even if the only consumer of this port was already python3, maybe somebody has the py2 version installed. > lib/python${MODPY_VERSION}/site-packages/humanize/ > > lib/python${MODPY_VERSION}/site-packages/humanize-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/ > > lib/python${MODPY_VERSION}/site-packages/humanize-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/PKG-INFO > @@ -10,12 +11,10 @@ lib/python${MODPY_VERSION}/site-packages > lib/python${MODPY_VERSION}/site-packages/humanize/__init__.py > > ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/humanize/${MODPY_PYCACHE}/ > > lib/python${MODPY_VERSION}/site-packages/humanize/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc > -lib/python${MODPY_VERSION}/site-packages/humanize/${MODPY_PYCACHE}compat.${MODPY_PYC_MAGIC_TAG}pyc > > lib/python${MODPY_VERSION}/site-packages/humanize/${MODPY_PYCACHE}filesize.${MODPY_PYC_MAGIC_TAG}pyc > > lib/python${MODPY_VERSION}/site-packages/humanize/${MODPY_PYCACHE}i18n.${MODPY_PYC_MAGIC_TAG}pyc > > lib/python${MODPY_VERSION}/site-packages/humanize/${MODPY_PYCACHE}number.${MODPY_PYC_MAGIC_TAG}pyc > > lib/python${MODPY_VERSION}/site-packages/humanize/${MODPY_PYCACHE}time.${MODPY_PYC_MAGIC_TAG}pyc > -lib/python${MODPY_VERSION}/site-packages/humanize/compat.py > lib/python${MODPY_VERSION}/site-packages/humanize/filesize.py > lib/python${MODPY_VERSION}/site-packages/humanize/i18n.py > lib/python${MODPY_VERSION}/site-packages/humanize/locale/ > @@ -23,6 +22,10 @@ lib/python${MODPY_VERSION}/site-packages > lib/python${MODPY_VERSION}/site-packages/humanize/locale/de_DE/LC_MESSAGES/ > > lib/python${MODPY_VERSION}/site-packages/humanize/locale/de_DE/LC_MESSAGES/humanize.mo > > lib/python${MODPY_VERSION}/site-packages/humanize/locale/de_DE/LC_MESSAGES/humanize.po > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/es_ES/ > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/es_ES/LC_MESSAGES/ > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/es_ES/LC_MESSAGES/humanize.mo > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/es_ES/LC_MESSAGES/humanize.po > lib/python${MODPY_VERSION}/site-packages/humanize/locale/fa_IR/ > lib/python${MODPY_VERSION}/site-packages/humanize/locale/fa_IR/LC_MESSAGES/ > > lib/python${MODPY_VERSION}/site-packages/humanize/locale/fa_IR/LC_MESSAGES/humanize.mo > @@ -55,10 +58,18 @@ lib/python${MODPY_VERSION}/site-packages > lib/python${MODPY_VERSION}/site-packages/humanize/locale/nl_NL/LC_MESSAGES/ > > lib/python${MODPY_VERSION}/site-packages/humanize/locale/nl_NL/LC_MESSAGES/humanize.mo > > lib/python${MODPY_VERSION}/site-packages/humanize/locale/nl_NL/LC_MESSAGES/humanize.po > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/pl_PL/ > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/pl_PL/LC_MESSAGES/ > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/pl_PL/LC_MESSAGES/humanize.mo > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/pl_PL/LC_MESSAGES/humanize.po > lib/python${MODPY_VERSION}/site-packages/humanize/locale/pt_BR/ > lib/python${MODPY_VERSION}/site-packages/humanize/locale/pt_BR/LC_MESSAGES/ > > lib/python${MODPY_VERSION}/site-packages/humanize/locale/pt_BR/LC_MESSAGES/humanize.mo > > lib/python${MODPY_VERSION}/site-packages/humanize/locale/pt_BR/LC_MESSAGES/humanize.po > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/pt_PT/ > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/pt_PT/LC_MESSAGES/ > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/pt_PT/LC_MESSAGES/humanize.mo > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/pt_PT/LC_MESSAGES/humanize.po > lib/python${MODPY_VERSION}/site-packages/humanize/locale/ru_RU/ > lib/python${MODPY_VERSION}/site-packages/humanize/locale/ru_RU/LC_MESSAGES/ > > lib/python${MODPY_VERSION}/site-packages/humanize/locale/ru_RU/LC_MESSAGES/humanize.mo > @@ -71,6 +82,10 @@ lib/python${MODPY_VERSION}/site-packages > lib/python${MODPY_VERSION}/site-packages/humanize/locale/tr_TR/LC_MESSAGES/ > > lib/python${MODPY_VERSION}/site-packages/humanize/locale/tr_TR/LC_MESSAGES/humanize.mo > > lib/python${MODPY_VERSION}/site-packages/humanize/locale/tr_TR/LC_MESSAGES/humanize.po > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/uk_UA/ > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/uk_UA/LC_MESSAGES/ > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/uk_UA/LC_MESSAGES/humanize.mo > +lib/python${MODPY_VERSION}/site-packages/humanize/locale/uk_UA/LC_MESSAGES/humanize.po > lib/python${MODPY_VERSION}/site-packages/humanize/locale/vi_VI/ > lib/python${MODPY_VERSION}/site-packages/humanize/locale/vi_VI/LC_MESSAGES/ > > lib/python${MODPY_VERSION}/site-packages/humanize/locale/vi_VI/LC_MESSAGES/humanize.mo > -- Paco Esteban. 0x5818130B8A6DBC03