On Sat, July 25, 2020 20:44, Stuart Henderson wrote:
> On 2020/07/25 18:30, Dimitri Karamazov wrote:
>
>> Any comments?
>>
>
>
> just use normal patches (plus SUBST_CMD if necessary e.g. where you are 
> adding X11BASE) rather than seds please.
>
> patch the input cmake file not the generated build.ninja file (don't assume 
> that it's using ninja to build, sometimes
> there are reasons to not use this)
>
>
Hi, and thanks for the comments!

I've made all the appropriate changes, let me know if there are any more.
Also corrected the patch file names.
I hope this gets in, it's an important synthesizer, probably the most
exhaustive imho.

I'll try Zyn-fusion sometime later, it has a more in place Gui.
Compare that to the default which is really a rabbit hole of tabs,
and difficult to deal with on some wm's.

OK?

regards,
  Dimitri

Attachment: zynaddsubfx.tar.gz
Description: application/gzip

Reply via email to