Hey some comments,
1. Why not use MODPY_PI instead of GH_*, to me it seems to be the standard
   for python modules. See pypi.org and set the DISTNAME & set PKGNAME maybe?
2. Since this is a module and not a standalone program, you should probably
   use FLAVORS and FLAVOR vars instead of MODPY_VERSION to enforce the python
   version, no?
3. Also the port should be labeled as py-synapse-ldap, in my opinion to follow
   suit with the rest of the python modules.
4. The source only list compatibility with python2, is that an issue? idk, I
   didn't test it.


Reply via email to