Hi Paul --

On Friday, July 10, 2020 11:26 AM, Paul Valencia <rei...@enmadechi.com> wrote:

> Hi ports,
>
> This is a new port for oshu which is a clone of osu! rhythm game.
> Currently it only supports playing the beatmaps of osu's Standard
> mode and you need to download them from internet (added some
> instructions about that in pkg README).
>
> Pass port-lib-depends-check and portcheck. Build on amd64 and arm64
> and only tested on amd64 with some beatmaps.

Thanks for the port. Attached is a tweaked version with the following:
* Improved COMMENT.
* It appears that upstream does not make any tarballs with their
releases, so switch to the GH_* variables. Has the benefit of taking
care of DISTNAME, PKGNAME, HOMEPAGE, and WRKDIST for you, so those
pieces were able to be removed.
* License marker is a little more explicit now with GPLv3 only.
* Put a comment (C++14) explaining the COMPILER line.
* Simplify LIB_DEPENDS.
* Use CONFIGURE_ARGS instead of a patch to deal with needing to add
-L${LOCALBASE}/lib in LDFLAGS.
* Add a patch to fix a -Wformat warning from clang.
* Fix some typos in pkg/README and hopefully make things a little bit
clearer. I didn't really understand what you meant by Standard until I
downloaded a beatmap that didn't work with oshu. I was able to follow
your directions to download a beatmap, unzip it, and play.

And I learned that I am very very bad at these types of games:

  brilliant
  ________ // Tokoyami Towa

  Normal
  By Hinsvar
  _ _ _ _

  Score:
   54 good
  391 miss

So I think I will stick with other genres for the time being, but it
was fun to try out oshu.

~Brian

Attachment: oshu.tgz
Description: application/compressed-tar

Reply via email to