On Sun, July 12, 2020 7:29 am, Antoine Jacoutot wrote: > On Sat, Jul 11, 2020 at 06:44:36PM -0000, Dimitri Karamazov wrote: > >> Hey, I hope you don't mind, but I'd like to take Maintainer since >> no one wants it. Only port worth saving among the list imao. I'll keep in >> touch with the upstream. >> >> >> This is an Prelease test build, so I marked it as alpha in version. >> Build and run-tested by making a monster in a T-pose with clubfoot. >> >> >> Index: Makefile >> =================================================================== >> RCS file: /cvs/ports/graphics/makehuman/Makefile,v >> retrieving revision 1.30 diff -u -p -r1.30 Makefile --- Makefile 10 Nov >> 2019 12:43:08 -0000 1.30 >> +++ Makefile 11 Jul 2020 18:28:47 -0000 >> @@ -2,37 +2,43 @@ >> >> >> COMMENT= parametrical modeling of 3D humanoid characters >> >> >> +PKGNAME= makehuman-1.2.0a >> + >> GH_ACCOUNT= makehumancommunity >> GH_PROJECT= makehuman >> -GH_TAGNAME= 1.1.1 >> +GH_TAGNAME= 1c6a4147eeec0f1f07f73904f33ebd4e8ef0065a >> >> >> CATEGORIES= graphics >> >> >> HOMEPAGE= http://www.makehumancommunity.org/ >> >> >> -# GPLv2 / MIT >> +MAINTAINER= Dimitri Karamazov <deserter...@danwin1210.me> >> + >> +# AGPLv3 >> PERMIT_PACKAGE= Yes >> >> >> MODULES= lang/python >> +MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3} >> >> >> -MODPY_BUILDDEP= No >> - >> -NO_BUILD= Yes >> NO_TEST= Yes >> >> >> RUN_DEPENDS= devel/desktop-file-utils \ >> - graphics/py-opengl \ >> - math/py-numpy \ >> - x11/py-qt4 >> + graphics/py-opengl${MODPY_FLAVOR} \ >> + math/py-numpy${MODPY_FLAVOR} \ >> + x11/py-qt5${MODPY_FLAVOR} >> >> >> +do-build: >> + cd ${WRKSRC}/makehuman && ${MODPY_BIN} ${MODPY_LIBDIR}/compileall.py . >> do-install: >> + ${INSTALL_DATA_DIR} ${PREFIX}/share/pixmaps >> + ${INSTALL_DATA} ${WRKSRC}/makehuman/icons/makehuman.png \ >> + ${PREFIX}/share/pixmaps >> ${INSTALL_DATA_DIR} ${PREFIX}/share/applications >> ${SUBST_CMD} -m 0644 -c -o ${SHAREOWN} -g ${SHAREGRP} \ >> ${FILESDIR}/MakeHuman.desktop.in \ >> ${PREFIX}/share/applications/MakeHuman.desktop >> ${SUBST_CMD} -m 0555 -c -o ${BINOWN} -g ${BINGRP} \ >> ${FILESDIR}/makehuman.in ${PREFIX}/bin/makehuman >> - cp -Rp ${WRKSRC}/makehuman ${PREFIX}/share/ >> - chown -r ${SHAREOWN}:${SHAREGRP} ${PREFIX}/share/makehuman/makehuman >> + @cp -Rp ${WRKSRC}/makehuman ${PREFIX}/share >> > > Why hiding this command? > > You mean the chown command? Because it does nothing. ${PREFIX}/share/makehuman/makehuman which is a binary already retains the proper own:grp which the chown attempts to do. So I deemed it unnecessary. Now it would be different if it was meant for the entire ${PREFIX}/share/makehuman dir, which the command explicitly is not. I'm ignorant of any need to do so for share dirs.
If you're point to '@cp', I don't know why I did it. I've seen it in other ports? But I'd like to know it's purpose, I will revert it if you want.
