On Tue, July 7, 2020 11:47 pm, Daniel Dickman wrote: > > > seems like it does everything except classify the finite simple groups > :-) > > > It's a nice port, but I had a few minor suggestions: Appreciate the feedback :)
> 1) I simplified the top of the Makefile so there's only one place for the
> version for future updates (see below)
> 2) for CONFIGURE_ARGS, can we put each arg on a new line?
Hey I've made the appropriate changes and reattched the port.
> 3) Too bad about USE_GMAKE. I think it gets close to building without
gnu > make except for the use of $< in a few Makefile.am files. Maybe
report > > upstream and see if they're willing to make slightly
> more portable?
Also I'll take the issue to upstream soon.
> 4) "make test" didn't work here. Not sure if I flubbed
> something on my end or you see the same thing. If it doesn't work add
> NO_TEST. If it can be
> made to work, even better.
The tests fail only because of a improper shebang.
sed -ie "s/bash/sh/" $(grep "bash" -R ${WRKSRC}/test | cut -d : -f 1)
And all should tests pass, as claimed. No need for NO_TEST.
Anyway I've added do-test: to the Makefile so no need to deal with that.
OK?
4ti2.tar.gz
Description: application/gzip
