On Sat, Jul 04, 2020 at 10:17:17AM +0100, Laurence Tratt wrote:
> Ouch, that didn't happen to me. I think that's the final nail in the coffin
> of trying to run tqdm's test suite! I've added a comment to the Makefile.
Not really. See what bsd.port.mk(5) says about NO_TEST:
Port does not have any regression tests. Only set to ‘Yes’ for
ports with no regression test. It should be left alone for ports
with empty regression tests, and for ports with failing tests.
That way, if a subsequent update of a port acquires actual
regression tests, they will be picked up automatically.
So we should leave NO_TEST unset and at least have a look at *why* these
failures occur: Are they systematic? Do we miss something on OpenBSD?
Does it depend on other packages (not) installed?
That said, I think we can do this in-tree; failing tests are not a
blocker for import.
> Aha, got it.
>
> Updates attached!
ffmpeg-normalize works just fine for me on amd64 and `make test' passes.
With NO_TEST from py-tqdm removed OK kn for other porters to import,
but I also take OKs for import :)
