On Sun, Jun 28, 2020 at 12:52:35PM +0200, Theo Buehler wrote: > On Fri, Jun 26, 2020 at 10:01:00PM -0700, Nam Nguyen wrote: > > Theo Buehler writes: > > > > > I was given a reliable reproducer for the sentinel segfault that seems > > > to be present since at least Redis 4. I can only reproduce on amd64 and > > > only when compiling with -O1 or -O2, but not with -O0. > > > > > >>From what I can tell, it is an out-of-bounds access trying to read from > > > a page without read permissions, hence the process is killed. It's > > > always the same line 2216 in sentinel.c: > > > > Here is a diff resolving the out-of-bounds memory access. > > Thank you very much for figuring this out. It never occurred to me to > look *after* the point where Redis crashed according to gdb, but once > you point it out the problem is clear... > > It would be great if you could make a PR https://github.com/antirez/redis > so you get proper credit, but if you don't want to, I can also take care > of this.
I forgot to say that I committed this.
