On 2020/06/27 15:37, Kinichiro Inoguchi wrote:
> Currently, lmms is disabling the ZynAddSubFX plugin.
> This diff enables it.
>
> - remove patches/patch-plugins_CMakeLists_txt to build zynaddsubfx
> - add required libraries to WANTLIB and LIB_DEPENDS
> - bump up REVISION to 1
>
> In this diff, I just delete all lines in patch-plugins_CMakeLists_txt.
> I would like to 'cvs remove' it if this diff is ok.
>
> I had confirmed that build and install on my OpenBSD 6.7 (amd64) succeeded.
> And I could play ZynAddSubFX within lmms.
>
> ok?
Doesn't seem to work here (I couldn't get it to work when I tried
before when I updated the port to 1.2.0).
I don't see ZynAddSubFX show up in the plugins list in lmms.
And I see this on the console when starting lmms,
lmms:/usr/local/lib/lmms/libZynAddSubFxCore.so: lmms : WARNING:
symbol(_ZTI6Effect) size mismatch, relink your program
lmms:/usr/local/lib/lmms/libZynAddSubFxCore.so: lmms : WARNING:
symbol(_ZTV6Effect) size mismatch, relink your program
"LMMS plugin /usr/local/lib/lmms/libZynAddSubFxCore.so does not have a plugin
descriptor named ZynAddSubFxCore_plugin_descriptor!"
$ make port-lib-depends-check
lmms-1.2.0p1(audio/lmms):
Extra: curses.14 fftw3.7 lo.0 mxml.0 readline.4
"make configure" output:
===> Configuring for lmms-1.2.0p1
-- The C compiler identification is Clang 8.0.1
-- The CXX compiler identification is Clang 8.0.1
-- Check for working C compiler: /usr/obj/ports/lmms-1.2.0/bin/cc
-- Check for working C compiler: /usr/obj/ports/lmms-1.2.0/bin/cc - works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/obj/ports/lmms-1.2.0/bin/c++
-- Check for working CXX compiler: /usr/obj/ports/lmms-1.2.0/bin/c++ - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Deprecation Warning at CMakeLists.txt:11 (CMAKE_POLICY):
The OLD behavior for policy CMP0026 will be removed from a future version
of CMake.
The cmake-policies(7) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances. Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.
CMake Deprecation Warning at CMakeLists.txt:13 (CMAKE_POLICY):
The OLD behavior for policy CMP0050 will be removed from a future version
of CMake.
The cmake-policies(7) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances. Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")
-- Found Git: /usr/local/bin/git (found version "2.24.2")
fatal: not a git repository (or any parent up to mount point /usr)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
Could not get project version. Using release info from /CMakeLists.txt
Configuring LMMS
--------------------------
* Project version : 1.2.0
* Major version : 1
* Minor version : 2
* Release version : 0
* Stage version :
* Build version : 0
*
Optional Version Usage:
--------------------------
* Override version: -DFORCE_VERSION=x.x.x-x
* Ignore Git information: -DFORCE_VERSION=internal
PROCESSOR: amd64
Machine: amd64-unknown-openbsd6.7
-- Target host is 64 bit
-- Looking for include file stdint.h
-- Looking for include file stdint.h - found
-- Looking for include file stdlib.h
-- Looking for include file stdlib.h - found
-- Looking for include file pthread.h
-- Looking for include file pthread.h - found
-- Looking for include file semaphore.h
-- Looking for include file semaphore.h - found
-- Looking for include file unistd.h
-- Looking for include file unistd.h - found
-- Looking for include file sys/types.h
-- Looking for include file sys/types.h - found
-- Looking for include file sys/ipc.h
-- Looking for include file sys/ipc.h - found
-- Looking for include file sys/shm.h
-- Looking for include file sys/shm.h - found
-- Looking for include file sys/time.h
-- Looking for include file sys/time.h - found
-- Looking for include file sched.h
-- Looking for include file sched.h - found
-- Looking for include file sys/soundcard.h
-- Looking for include file sys/soundcard.h - not found
-- Looking for include file soundcard.h
-- Looking for include file soundcard.h - found
-- Looking for include file fcntl.h
-- Looking for include file fcntl.h - found
-- Looking for include file sys/ioctl.h
-- Looking for include file sys/ioctl.h - found
-- Looking for include file ctype.h
-- Looking for include file ctype.h - found
-- Looking for include file string.h
-- Looking for include file string.h - found
-- Looking for include file process.h
-- Looking for include file process.h - not found
-- Looking for include file locale.h
-- Looking for include file locale.h - found
-- Checking for module 'sndfile>=1.0.11'
-- Found sndfile, version 1.0.28
CMake Warning (dev) at
/usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:272
(message):
The package name passed to `find_package_handle_standard_args` (PkgConfig)
does not match the name of the calling package (Portaudio). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
/usr/local/share/cmake/Modules/FindPkgConfig.cmake:45
(find_package_handle_standard_args)
cmake/modules/FindPortaudio.cmake:20 (include)
CMakeLists.txt:286 (FIND_PACKAGE)
This warning is for project developers. Use -Wno-dev to suppress it.
-- Checking for module 'portaudio-2.0'
-- Found portaudio-2.0, version 19
-- Found Portaudio: portaudio
CMake Warning (dev) at
/usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:272
(message):
The package name passed to `find_package_handle_standard_args` (SOUNDIO)
does not match the name of the calling package (SoundIo). This can lead to
problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
cmake/modules/FindSoundIo.cmake:14 (find_package_handle_standard_args)
CMakeLists.txt:298 (FIND_PACKAGE)
This warning is for project developers. Use -Wno-dev to suppress it.
-- Could NOT find SOUNDIO (missing: SOUNDIO_LIBRARY SOUNDIO_INCLUDE_DIR)
-- Found Lame: /usr/local/include
-- Looking for vorbis_bitrate_addblock in vorbis
-- Looking for vorbis_bitrate_addblock in vorbis - found
-- Found OggVorbis:
/usr/local/lib/libogg.so.6.2;/usr/local/lib/libvorbis.so.9.0;/usr/local/lib/libvorbisfile.so.6.0;/usr/local/lib/libvorbisenc.so.3.1
-- Looking for snd_seq_create_simple_port in asound
-- Looking for snd_seq_create_simple_port in asound - not found
-- ALSA not found
-- Looking for include file machine/soundcard.h
-- Looking for include file machine/soundcard.h - not found
-- Looking for include file linux/awe_voice.h
-- Looking for include file linux/awe_voice.h - not found
-- Looking for include file awe_voice.h
-- Looking for include file awe_voice.h - not found
-- Looking for include file /usr/src/sys/i386/isa/sound/awe_voice.h
-- Looking for include file /usr/src/sys/i386/isa/sound/awe_voice.h - not found
-- Looking for include file /usr/src/sys/gnu/i386/isa/sound/awe_voice.h
-- Looking for include file /usr/src/sys/gnu/i386/isa/sound/awe_voice.h - not
found
-- Looking for C++ include sys/asoundlib.h
-- Looking for C++ include sys/asoundlib.h - not found
-- Looking for C++ include alsa/asoundlib.h
-- Looking for C++ include alsa/asoundlib.h - not found
-- Looking for snd_pcm_resume in asound
-- Looking for snd_pcm_resume in asound - not found
-- Checking for module 'jack>=0.77'
-- Found jack, version 0.125.0
-- Checking for module 'fftw3f>=3.0.0'
-- Found fftw3f, version 3.3.8
-- Found OpenGL: /usr/X11R6/lib/libGL.so.17.1
CMake Warning (dev) at
/usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:272
(message):
The package name passed to `find_package_handle_standard_args` (X11) does
not match the name of the calling package (FLTK). This can lead to
problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
/usr/local/share/cmake/Modules/FindX11.cmake:366
(find_package_handle_standard_args)
/usr/local/share/cmake/Modules/FindFLTK.cmake:98 (include)
CMakeLists.txt:407 (FIND_PACKAGE)
This warning is for project developers. Use -Wno-dev to suppress it.
-- Found X11: /usr/X11R6/include
-- Looking for XOpenDisplay in
/usr/X11R6/lib/libX11.so.17.0;/usr/X11R6/lib/libXext.so.13.0
-- Looking for XOpenDisplay in
/usr/X11R6/lib/libX11.so.17.0;/usr/X11R6/lib/libXext.so.13.0 - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found FLTK:
/usr/local/lib/libfltk_images.so.8.0;/usr/local/lib/libfltk_forms.so.8.0;/usr/local/lib/libfltk_gl.so.8.0;/usr/X11R6/lib/libGL.so.17.1;/usr/local/lib/libfltk.so.8.0
-- Checking for module 'fluidsynth>=1.0.7'
-- Found fluidsynth, version 2.1.2
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Looking for sio_open in sndio
-- Looking for sio_open in sndio - found
CMake Warning (dev) at
/usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:272
(message):
The package name passed to `find_package_handle_standard_args` (SNDIO) does
not match the name of the calling package (Sndio). This can lead to
problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
cmake/modules/FindSndio.cmake:27 (find_package_handle_standard_args)
CMakeLists.txt:439 (FIND_PACKAGE)
This warning is for project developers. Use -Wno-dev to suppress it.
-- Found SNDIO: /usr/lib/libsndio.so.7.1
CMake Warning (dev) in cmake/modules/FindSndio.cmake:
A logical block opening on the line
/usr/obj/ports/lmms-1.2.0/lmms-1.2.0/cmake/modules/FindSndio.cmake:29 (if)
closes on the line
/usr/obj/ports/lmms-1.2.0/lmms-1.2.0/cmake/modules/FindSndio.cmake:32
(endif)
with mis-matching arguments.
Call Stack (most recent call first):
CMakeLists.txt:439 (FIND_PACKAGE)
This warning is for project developers. Use -Wno-dev to suppress it.
-- Checking for module 'samplerate>=0.1.8'
-- Found samplerate, version 0.1.9
(reading log message from standard input)
CMake Deprecation Warning at plugins/carlabase/CMakeLists.txt:6 (CMAKE_POLICY):
The OLD behavior for policy CMP0068 will be removed from a future version
of CMake.
The cmake-policies(7) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances. Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.
-- Found UnixCommands: /usr/local/bin/bash
-- Checking for module 'bash-completion'
--
-- Bash completion script for lmms will be installed to
/usr/share/bash-completion/completions or fallback to
/usr/local/share/bash-completion/completions if unwritable.
Installation Summary
--------------------
* Install Directory : /usr/local
Supported audio interfaces
--------------------------
* ALSA : not found, please install libasound2-dev (or
similar) ;if you require ALSA support
* JACK : OK (weak linking enabled)
* OSS : <not found or not supported on this platform>
* Sndio : OK
* PortAudio : OK
* libsoundio : not found, please install libsoundio if you
require libsoundio support
* PulseAudio :
* SDL :
Supported MIDI interfaces
-------------------------
* ALSA : not found, please install libasound2-dev (or
similar) ;if you require ALSA support
* OSS : <not found or not supported on this platform>
* Sndio : OK
* JACK : OK (weak linking enabled)
* WinMM : <not supported on this platform>
* AppleMidi : <not supported on this platform>
Supported file formats for project export
-----------------------------------------
* WAVE : OK
* OGG/VORBIS : OK
* MP3/Lame : OK
Optional plugins
----------------
* Carla Patchbay & Rack :
* SoundFont2 player : OK
* Stk Mallets :
* VST-instrument hoster :
* VST-effect hoster :
* CALF LADSPA plugins : not built as requested
* CAPS LADSPA plugins : not built as requested
* CMT LADSPA plugins : not built as requested
* TAP LADSPA plugins : not built as requested
* SWH LADSPA plugins : not built as requested
* GIG player :
-----------------------------------------------------------------
IMPORTANT:
after installing missing packages, remove CMakeCache.txt before
running cmake again!
-----------------------------------------------------------------
-- Configuring done
CMake Warning (dev) in src/CMakeLists.txt:
Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.
Run "cmake --help-policy CMP0071" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
For compatibility, CMake is excluding the GENERATED source file(s):
"/usr/obj/ports/lmms-1.2.0/build-amd64/src/embedded_resources.h"
from processing by AUTOMOC. If any of the files should be processed, set
CMP0071 to NEW. If any of the files should not be processed, explicitly
exclude them by setting the source file property SKIP_AUTOMOC:
set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)
This warning is for project developers. Use -Wno-dev to suppress it.
-- Generating done
-- Build files have been written to: /usr/obj/ports/lmms-1.2.0/build-amd64
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/audio/lmms/Makefile,v
> retrieving revision 1.23
> diff -u -p -u -p -r1.23 Makefile
> --- Makefile 30 Jan 2020 14:13:47 -0000 1.23
> +++ Makefile 27 Jun 2020 06:34:22 -0000
> @@ -5,7 +5,7 @@ COMMENT = music studio with tracking, s
> # rolled from git; requires submodules
> # git clone --recurse-submodules -b v1.2.0 https://github.com/lmms/lmms
> DISTNAME = lmms-1.2.0
> -REVISION = 0
> +REVISION = 1
> EXTRACT_SUFX = .tar.xz
>
> CATEGORIES = audio
> @@ -18,9 +18,10 @@ MASTER_SITES = https://spacehopper.org/
> PERMIT_PACKAGE = Yes
>
> WANTLIB += ${COMPILER_LIBCXX} Qt5Core Qt5Gui Qt5Widgets Qt5Xml
> -WANTLIB += c curses fftw3f fluidsynth jack m mp3lame ogg portaudio
> -WANTLIB += readline samplerate sndfile sndio vorbis vorbisenc
> -WANTLIB += vorbisfile
> +WANTLIB += Xau Xcursor Xdmcp Xext Xfixes Xft Xinerama
> +WANTLIB += c curses fftw3 fftw3f fluidsynth fltk fontconfig jack lo
> +WANTLIB += m mp3lame mxml ogg portaudio readline samplerate sndfile sndio
> +WANTLIB += vorbis vorbisenc vorbisfile z
>
> COMPILER = base-clang ports-gcc
>
> @@ -32,13 +33,18 @@ BUILD_DEPENDS = shells/bash
> RUN_DEPENDS = devel/desktop-file-utils \
> misc/shared-mime-info \
> x11/gtk+3,-guic
> +
> LIB_DEPENDS = audio/fluidsynth \
> audio/jack \
> audio/lame \
> + audio/liblo \
> audio/libsamplerate \
> audio/libvorbis \
> audio/portaudio-svn \
> - math/fftw3,float
> + math/fftw3 \
> + math/fftw3,float \
> + textproc/mxml \
> + x11/fltk
>
> CONFIGURE_ENV = CFLAGS="${CFLAGS} -I${X11BASE}/include
> -I${LOCALBASE}/include" \
> CXXFLAGS="${CXXFLAGS} -I${X11BASE}/include
> -I${LOCALBASE}/include" \
> Index: patches/patch-plugins_CMakeLists_txt
> ===================================================================
> RCS file: /cvs/ports/audio/lmms/patches/patch-plugins_CMakeLists_txt,v
> retrieving revision 1.1
> diff -u -p -u -p -r1.1 patch-plugins_CMakeLists_txt
> --- patches/patch-plugins_CMakeLists_txt 24 Jun 2018 11:57:13 -0000
> 1.1
> +++ patches/patch-plugins_CMakeLists_txt 27 Jun 2020 06:34:22 -0000
> @@ -1,14 +0,0 @@
> -$OpenBSD: patch-plugins_CMakeLists_txt,v 1.1 2018/06/24 11:57:13 sthen Exp $
> -
> -Index: plugins/CMakeLists.txt
> ---- plugins/CMakeLists.txt.orig
> -+++ plugins/CMakeLists.txt
> -@@ -80,7 +80,7 @@ IF("${PLUGIN_LIST}" STREQUAL "")
> - watsyn
> - waveshaper
> - vibed
> -- zynaddsubfx
> -+# zynaddsubfx
> - )
> -
> - ENDIF("${PLUGIN_LIST}" STREQUAL "")
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/audio/lmms/pkg/PLIST,v
> retrieving revision 1.7
> diff -u -p -u -p -r1.7 PLIST
> --- pkg/PLIST 30 Jan 2020 14:13:47 -0000 1.7
> +++ pkg/PLIST 27 Jun 2020 06:34:22 -0000
> @@ -1,7 +1,9 @@
> @comment $OpenBSD: PLIST,v 1.7 2020/01/30 14:13:47 sthen Exp $
> @bin bin/lmms
> lib/lmms/
> +@bin lib/lmms/RemoteZynAddSubFx
> @so lib/lmms/libOPL2.so
> +@so lib/lmms/libZynAddSubFxCore.so
> @so lib/lmms/libamplifier.so
> @so lib/lmms/libaudiofileprocessor.so
> @so lib/lmms/libbassbooster.so
> @@ -38,6 +40,7 @@ lib/lmms/
> @so lib/lmms/libvibedstrings.so
> @so lib/lmms/libwatsyn.so
> @so lib/lmms/libwaveshaper.so
> +@so lib/lmms/libzynaddsubfx.so
> @man man/man1/lmms.1
> share/applications/lmms.desktop
> share/bash-completion/completions/lmms
>
