On Thu, Jun 25, 2020 at 06:08:56PM +0200, Omar Polo wrote:
>
> Hello there!
>
> Attached the port for Lucene++, a port of the java lucene library. It's
> required by newer version of devel/poedit.
>
> The patches against the three CMakefiles are to disable cotire, as it
> breaks the build. The patch against VariantUtils.h is to support newer
> version of boost. These patches are heavily inspired (read: copied)
> from the freebsd port.
>
> I'm not sure about the two patches against the .pc files, because by
> default it generates something like
>
> Libs: -L/usr/local//usr/local/lib
>
> which is broken. Comments appreciated.
i had a look, and its indeed a bit strange - your fix makes sense but
why not consistently using LIB_DESTINATION in the patches ?
what's breaking with cotire ? care to add comments in the patches
explaining the failures ?
> It builds on amd64, passes make port-lib-depends-check and portcheck.
>
> NO_TEST is Yes because the port doesn't contain tests, is it right?
There are tests in src/test, using a bundled copy of gtest (that should
be patched to use the gtest from the ports, which should be added as a
build/test dependency i think).
granted, if i uncomment NO_TEST, it defaults to use ctest from cmake
which doesnt find any tests.
/usr/ports/mystuff/textproc/luceneplusplus/ $make test
===> Regression tests for luceneplusplus-3.0.7
[0/1] cd /usr/obj/ports/luceneplusplus-3.0.7/build-amd64 &&
/usr/local/bin/ctest --force-new-ctest-process --exclude-regex
"CMake.FileDownload|CTestTestUpload|RunCMake.ctest_submit"
Test project /usr/obj/ports/luceneplusplus-3.0.7/build-amd64
No tests were found!!!
But README.rst points at lucene++-tester in the build dir, which indeed
runs some unit testing:
/usr/obj/ports/luceneplusplus-3.0.7/LucenePlusPlus-rel_3.0.7/$
../build-amd64/src/test/lucene++-tester
[==========] Running 1472 tests from 201 test cases.
[----------] Global test environment set-up.
[----------] 1 test from VersionTest
[ RUN ] VersionTest.testVersion
[ OK ] VersionTest.testVersion (1 ms)
[----------] 1 test from VersionTest (1 ms total)
...
so maybe you need a do-test target running this binary from ${WRKBUILD}
Landry
