On Sun, Jun 14 2020, Paco Esteban <p...@e1e0.net> wrote: > On Sat, 13 Jun 2020, Paco Esteban wrote: > >> On Sat, 13 Jun 2020, Paco Esteban wrote: >> >> > Hi, >> > >> > As suggested by sthen@ we can drop py2 for devel/py-wbem. >> > >> > I took the opportunity to update it to its latest version. I cannot >> > (or don't know how to) test this myself and the pypi distfile does not >> > include the tests (I opened an issue for this on their github repo), so >> > if somebody can test it it would be nice. >> > >> > Comments ? ok ? >> >> Here it is again against the latest version in the ports tree and >> including some suggestions from sthen@ > > And here it is one more time to adapt to the latest commit by ajacoutot@
Setting both TEST_DEPENDS and NO_TEST=Yes is dubious, why install deps if you won't run the tests and have a chance to verify that the TEST_DEPENDS are indeed correct? Anyway, NO_TEST=Yes isn't appropriate here, see bsd.port.mk(5). A simple fix is to drop NO_TEST=Yes and the related comment, and keep TEST_DEPENDS since they look correct (make test tries to download them if not installed, and fails in a PORTS_PRIVSEP setup). With this addressed, ok jca@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
