On Tue Jun 16, 2020 at 10:10:58AM +0100, Laurence Tratt wrote:
> neovim-qt is a simple QT5 GUI front-end for neovim. I've been using this on
> OpenBSD for over a year but have held back from submitting a formal port
> because the tests failed before 0.2.16. They now pass -- sort of. "make test"
> fails all of the tests, but if you run them in a normal terminal they all
> succeed. I'm not exactly sure why, but presumably because they're being
> called via a pipe of some sort rather than via a normal terminal. Ideas
> welcome on if/how to fix that!
> 
> 

Tweaked/Improved version:

- Use tabs
- Fix cleanup dependencies
- Setup python to build bindings
- Disable doxygen
- Use system msgpack
- The test suite needs X11
  - 100% tests passed, 0 tests failed out of 17

Laurence Tratt, are you agree with this changes?

I would import it with these changes. Is another one okay?


--- Makefile.orig       Tue Jun 16 22:04:00 2020
+++ Makefile    Wed Jun 17 07:21:25 2020
@@ -1,6 +1,6 @@
 # $OpenBSD: Makefile.template,v 1.79 2019/03/03 23:18:37 sthen Exp $
 
-COMMENT = QT5 GUI front-end for neovim
+COMMENT =      Qt5 GUI front-end for neovim
 
 GH_ACCOUNT = equalsraf
 GH_PROJECT = neovim-qt
@@ -8,26 +8,34 @@ GH_TAGNAME = v0.2.16
 
 CATEGORIES = editors
 
-HOMEPAGE = https://github.com/equalsraf/neovim-qt/wiki
-
 MAINTAINER = Laurence Tratt <lau...@tratt.net>
 
 # ISC
 PERMIT_PACKAGE = Yes
 
-WANTLIB += ${COMPILER_LIBCXX} Qt5Core Qt5Gui Qt5Network Qt5Svg Qt5Widgets
-WANTLIB += c m
+WANTLIB += ${COMPILER_LIBCXX} Qt5Core Qt5Gui Qt5Network Qt5Svg
+WANTLIB += Qt5Widgets c m msgpackc
 
-MODULES = devel/cmake x11/qt5
+MODULES =      devel/cmake \
+               lang/python \
+               x11/qt5
 
-BUILD_DEPENDS = devel/cmake \
-                devel/ninja \
-                editors/neovim
-LIB_DEPENDS = x11/qt5/qtsvg
-RUN_DEPENDS = devel/desktop-file-utils \
-              editors/neovim \
-              x11/xclip
+MODPY_VERSION =        ${MODPY_DEFAULT_VERSION_3}
+MODPY_RUNDEP = Yes
 
-SEPARATE_BUILD = Yes
+BUILD_DEPENDS =        editors/neovim
+
+LIB_DEPENDS =  devel/msgpack \
+               x11/qt5/qtsvg
+
+RUN_DEPENDS =  devel/desktop-file-utils \
+               editors/neovim \
+               x11/gtk+3,-guic \
+               x11/xclip
+
+CONFIGURE_ARGS =       -DUSE_SYSTEM_MSGPACK=On \
+                       -DCMAKE_DISABLE_FIND_PACKAGE_Doxygen=On
+
+TEST_IS_INTERACTIVE = X11
 
 .include <bsd.port.mk>

Reply via email to