On Mon, Jun 15, 2020 at 01:39:11PM +0200, Marc Espie wrote: > The idea looks fine, I"m not quite sure it works nor is perfect. Why would it not work?
> [ ] && echo will only succeed if the first part succeeds, ouch. That's the point: list patches only if there are any to list in the first place. > I would just display failed patches if $$error, the "can't find patch > matching $$i" happens so seldom that it won't be confusing. Why have inconsistent output in those seldom cases if we can do it properly for relevant cases only? > You do not need to initialize the variable. It adds to readability and, depending on sh's -e and/or -u usage, using the variable unconditionally as you suggest could fail without it being initialised.
