On Mon, Jun 01 2020, Stuart Henderson <s...@spacehopper.org> wrote:
> This is a maintained pure-Python mysql/mariadb client library.
> The new version of LibreNMS wants it (I can patch around that, but
> it seems useful to have anyway). I chose not to force the optional
> dependency on py-rsa because pulls in the fairly large (and not
> pure-Python) py-cryptography.
Leaving py-cryptography out of rundeps makes sense to me, mariadb (which
is our primary target) doesn't implement those auth methods server-side.
> OK to import?
ok jca@ with the point below addressed.
> ------
> PyMySQL is a pure-Python MySQL client library, based on PEP 249.
> Most public APIs are compatible with mysqlclient and MySQLdb.
>
> If you would like to use "sha256_password" or "caching_sha2_password"
> for authentication, you need to also install the ${MODPY_PY_PREFIX}rsa
> package.
> ------
--8<--
russell /usr/ports/pobj/py-pymysql-0.9.3-python3/PyMySQL-0.9.3$ grep -C1 rsa
setup.py
extras_require={
"rsa": ["cryptography"],
},
-->8--
"rsa" is the name of the extra functionality of PyMySQL which depends on
the cryptography module. So I think you should mention py-cryptography in
pkg/DESCR, not py-rsa.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
