On Sun, 31 May 2020 20:25:30 +0100
Stuart Henderson <s...@spacehopper.org> wrote:
> On 2020/05/31 00:33, Juan Francisco Cantero Hurtado wrote:
> > This package is a dependency of another new package. OK?
> >
> > ----
> > Information for inst:py3-patiencediff-0.1.0
> >
> > Comment:
> > python implementation of the patiencediff algorithm
>
> capital 'P' for Python please, and I think this would be better in
> textproc/ (like gdiff) rather than devel/.
>
> otherwise OK.
>
> > - A C implementation implementation (_patiencediff_c.c); this
> > implementation is faster, but requires a C compiler and is less
> > readable
>
> A bunch of tests are skipped, running with 'make MODPY_PYTEST_ARGS="-v
> patiencediff" test' shows the details and it turns out these are the
> tests for the C version. Could you either add
>
> MODPY_TEST_DIR = ${WRKSRC}/lib*
>
> or fix it another way please?
Committed with all your suggestions. Thanks for the help.
>
>
> $ make MODPY_PYTEST_ARGS="-v patiencediff" test
> ===> Regression tests for py3-patiencediff-0.1.0
> ============================= test session starts
> ============================== platform openbsd6 -- Python 3.7.7,
> pytest-4.4.0, py-1.8.0, pluggy-0.11.0 -- /usr/local/bin/python3.7
> cachedir: .pytest_cache hypothesis profile 'default' ->
> database=DirectoryBasedExampleDatabase('/usr/obj/ports/py-patiencediff-0.1.0-python3/patiencediff-0.1.0/.hypothesis/examples')
> rootdir:
> /usr/obj/ports/py-patiencediff-0.1.0-python3/patiencediff-0.1.0
> plugins: hypothesis-4.15.0 collecting ... collected 26 items
>
> patiencediff/test_patiencediff.py::TestPatienceDiffLib::test_diff_unicode_string
> PASSED [ 3%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib::test_grouped_opcodes
> PASSED [ 7%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib::test_matching_blocks
> PASSED [ 11%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib::test_matching_blocks_tuples
> PASSED [ 15%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib::test_multiple_ranges
> PASSED [ 19%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib::test_opcodes
> PASSED [ 23%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib::test_patience_unified_diff
> PASSED [ 26%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib::test_patience_unified_diff_with_dates
> PASSED [ 30%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib::test_recurse_matches
> PASSED [ 34%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib::test_unique_lcs
> PASSED [ 38%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib_c::test_diff_unicode_string
> SKIPPED [ 42%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib_c::test_grouped_opcodes
> SKIPPED [ 46%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib_c::test_matching_blocks
> SKIPPED [ 50%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib_c::test_matching_blocks_tuples
> SKIPPED [ 53%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib_c::test_multiple_ranges
> SKIPPED [ 57%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib_c::test_opcodes
> SKIPPED [ 61%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib_c::test_patience_unified_diff
> SKIPPED [ 65%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib_c::test_patience_unified_diff_with_dates
> SKIPPED [ 69%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib_c::test_recurse_matches
> SKIPPED [ 73%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib_c::test_unhashable
> SKIPPED [ 76%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLib_c::test_unique_lcs
> SKIPPED [ 80%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLibFiles::test_patience_unified_diff_files
> PASSED [ 84%]
> patiencediff/test_patiencediff.py::TestPatienceDiffLibFiles_c::test_patience_unified_diff_files
> SKIPPED [ 88%]
> patiencediff/test_patiencediff.py::TestUsingCompiledIfAvailable::test_PatienceSequenceMatcher
> PASSED [ 92%]
> patiencediff/test_patiencediff.py::TestUsingCompiledIfAvailable::test_recurse_matches
> PASSED [ 96%]
> patiencediff/test_patiencediff.py::TestUsingCompiledIfAvailable::test_unique_lcs
> PASSED [100%]
>
> ==================== 14 passed, 12 skipped in 0.15 seconds
> =====================
>
>
--
Juan Francisco Cantero Hurtado http://juanfra.info
