Bryan Steele <bry...@gmail.com> writes:

On Wed, May 27, 2020 at 09:33:57PM +0200, Omar Polo wrote:

Hi,

This is a port for picom, a compositor for X11. It's an actively
developed fork of compton.

I've been running for a month now, and it has been rock stable (instead
of compton which would occasionally crash.)

Build and tested on amd64, passes port-lib-depends-check and portcheck.

A couple of notes about the patches:

- (AFAIK) the project was recently renamed from "compton" to "picom", that's the reason they install some files that can conflict with
  x11/compton (like the bin/compton{,-trans} links to
bin/picom{,-trans}). I've removed (and/or renamed) them to avoid the conflict, since I wanted to have them both installed side-by-side

- moved the manpage from the (port) default share/man/man1 to
  man/man1

- the patch-src_meson_build is an hack to avoid a meson error I cannot
  understand

Cheers!


I can't comment on the port itself, but picom looks like it needs a similar fix for vsync as compton in ports does to use the correct
drm(4) device node.

-Bryan.

diff --git src/vsync.c src/vsync.c
index 5980155..8273d28 100644
--- src/vsync.c
+++ src/vsync.c
@@ -54,7 +54,7 @@ static int vsync_drm_wait(session_t *ps) {
  */
 static bool vsync_drm_init(session_t *ps) {
        // Should we always open card0?
- if (ps->drm_fd < 0 && (ps->drm_fd = open("/dev/dri/card0", O_RDWR)) < 0) { + if (ps->drm_fd < 0 && (ps->drm_fd = open("/dev/drm0", O_RDWR)) < 0) {
                log_error("Failed to open device.");
                return false;
        }

Thanks for finding this!

attaching an updated tarball with this and the patch by Jan Beich.

Attachment: picom.tar.gz
Description: Binary data

Reply via email to