Le Mon, 13 Apr 2020 21:24:01 +0200,
Solene Rapenne <sol...@perso.pw> a écrit :

> On Fri, Apr 10, 2020 at 12:39:33PM -0500, Paul Valencia wrote:
> > On Fri, Apr 10, 2020 at 01:44:54PM +0200, Solene Rapenne wrote:  
> > > On Fri, Apr 10, 2020 at 02:40:22AM -0500, Paul Valencia wrote:  
> > > > Hi,
> > > > 
> > > > Here is a new port for the wrath-darkplaces engine [1]
> > > > which is used in the game WRATH: Aeon of Ruin.
> > > > 
> > > > Some notes about this:
> > > > 
> > > > - There is no release, so I used GH_COMMIT
> > > > 
> > > > - Pass port-lib-depends-check and portcheck
> > > > 
> > > > - I used games/xonotic as a reference for this port
> > > > since it is related to the darkplaces engine.
> > > > 
> > > > - I renamed the binary to wrath as a recommendation
> > > > here [2]
> > > > 
> > > > - I tested the three levels of the game on amd64
> > > > 
> > > > - In the game, I found an issue with the mouse when
> > > > you have different artifacts(3+) in your inventory
> > > > that only allows you to select the extreme left/right
> > > > artifact.
> > > > 
> > > > OK's? Comments?
> > > > 
> > > > [1] https://github.com/KillPixelGames/wrath-darkplaces
> > > > [2] https://github.com/KillPixelGames/wrath-darkplaces#running  
> > > 
> > > the port looks fine to me (and works well) altough
> > > 
> > > - README should explain that you need to run wrath binary in a
> > > directory where the folder kp1 is available, or that you can use
> > > some args for that (at least the game tell you to use -basedir to
> > > find the assets)
> > > - version maybe be 20200228 instead of adding 0.0.0 as a prefix to
> > >   commit date?  
> > 
> > Here is the port with the README change. I use the prefix 0.0.0
> > for the version because there may be an official release in the
> > future (e.g. 1.X.X) and to avoid EPOCH if that happens.
> > 
> > Thanks for your input.  
> 
> indeed, the prefix 0.0.0 make sense in that case you showed me others
> ports do the same.
> 
> I'm ok to import it. Anyone else ok?
> 

ping

Reply via email to