On Thu, May 14 2020, Kurt Mosiejczuk <k...@cranky.work> wrote:
> On Thu, May 14, 2020 at 03:22:27PM +0200, Theo Buehler wrote:
>> This an optional runtime dependency that speeds up the some of the
>> tlsfuzzer tests quite a bit (by a factor of 4-6 on my laptop) simply by
>> replacing the native python crypto implementations by faster versions.
>
>> This is purely convenience. I can also add two packages, but I would
>> expect this to make everyone's lives easier (especially other LibreSSL
>> devs who will hopefully be running these tests from time to time).
>
>> The current test script I have in my tree takes about 3 minutes with
>> py-M2Crypto installed, without it, we're talking 15-20 minutes.
>
> Sounds good. Probably will prevent a future phantom failure if py-M2Crypto
> gets junked during build.
Adding m2crypto to RUN_DEPENDS won't prevent a failure at build
time.
> ok kmos
Meanwhile, tb@ and I discussed whether the rdep should be added here or
in py-tlslite-ng, looks like he opted for the latter.
> --Kurt
>
>> Index: Makefile
>> ===================================================================
>> RCS file: /var/cvs/ports/security/py-tlsfuzzer/Makefile,v
>> retrieving revision 1.3
>> diff -u -p -r1.3 Makefile
>> --- Makefile 15 Mar 2020 05:45:03 -0000 1.3
>> +++ Makefile 14 May 2020 12:59:36 -0000
>> @@ -6,6 +6,7 @@ MODPY_EGG_VERSION = 20200313
>> DISTNAME = tlsfuzzer-${MODPY_EGG_VERSION}
>> PKGNAME = py-${DISTNAME}
>> CATEGORIES = security
>> +REVISION = 0
>>
>> GH_ACCOUNT = tomato42
>> GH_PROJECT = tlsfuzzer
>> @@ -20,7 +21,8 @@ FLAVORS = python3
>>
>> WANTLIB += ${MODPY_WANTLIB}
>>
>> -RUN_DEPENDS += net/py-tlslite-ng${MODPY_FLAVOR}
>> +RUN_DEPENDS += net/py-tlslite-ng${MODPY_FLAVOR} \
>> + security/py-M2Crypto${MODPY_FLAVOR}
>>
>> # GPLv2
>> PERMIT_PACKAGE = Yes
>>
>
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
