On Tue, Apr 28, 2020 at 01:38:08PM -0400, Brian Callahan wrote:
> This is not broken. I use it.
> You need to set up an API key to use it though, as documented on upstream's
> GitHub repo:
> https://github.com/flaviotordini/minitube
Thanks.
Google is now requiring an API key in order to access YouTube
Data web services. Create a "Browser Key" at
https://console.developers.google.com and enable the Youtube
Data API.
The key must be specified at compile time as shown below.
Alternatively Minitube can read an API key from the
GOOGLE_API_KEY environment variable.
Following the quoted link leads to a login page, so it seems that users
without Google account cannot obtain an API key.
I see we're patching an API key, but that one obviously does not work.
Since it requires a login, it seems to me that this does not belong into
our ports tree; it is private information.
Diff below removes the patch and therefore requires minitube to work
with an API key provided through the environment variable; I have
simply taken upstream's wording.
Feedback? OK?
Index: Makefile
===================================================================
RCS file: /cvs/ports/www/minitube/Makefile,v
retrieving revision 1.64
diff -u -p -r1.64 Makefile
--- Makefile 30 Mar 2020 04:01:01 -0000 1.64
+++ Makefile 28 Apr 2020 17:52:31 -0000
@@ -5,7 +5,7 @@ COMMENT = standalone YouTube.com video b
V = 3.3
DISTNAME = minitube-$V
EXTRACT_SUFX = .tar.bz2
-REVISION = 0
+REVISION = 1
CATEGORIES = www multimedia
Index: patches/patch-minitube_pro
===================================================================
RCS file: patches/patch-minitube_pro
diff -N patches/patch-minitube_pro
--- patches/patch-minitube_pro 7 Sep 2019 19:38:57 -0000 1.2
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,13 +0,0 @@
-$OpenBSD: patch-minitube_pro,v 1.2 2019/09/07 19:38:57 sthen Exp $
-
-Index: minitube.pro
---- minitube.pro.orig
-+++ minitube.pro
-@@ -11,6 +11,7 @@ APP_UNIX_NAME = minitube
- DEFINES += APP_UNIX_NAME="$$APP_UNIX_NAME"
-
- DEFINES += APP_SNAPSHOT
-+DEFINES += APP_GOOGLE_API_KEY=AIzaSyClNIH5RZEdJA0286p_Km4hMxL0ujgdbZM
-
- message(Building $${APP_NAME} $${VERSION})
- message(Qt $$[QT_VERSION] in $$[QT_INSTALL_PREFIX])
Index: pkg/MESSAGE
===================================================================
RCS file: pkg/MESSAGE
diff -N pkg/MESSAGE
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ pkg/MESSAGE 28 Apr 2020 17:57:49 -0000
@@ -0,0 +1,5 @@
+Google is now requiring an API key in order to access YouTube Data web
services.
+Create a "Browser Key" at https://console.developers.google.com and enable the
+Youtube Data API.
+
+The key must be specified as the GOOGLE_API_KEY environment variable.
