Hi Marc,

Marc Espie wrote on Mon, Apr 27, 2020 at 10:20:13AM +0200:

> Let's try anyway.

Looks good to me except for the nits below.

Yours,
  Ingo


> Index: ports.7
> ===================================================================
> RCS file: /cvs/src/share/man/man7/ports.7,v
> retrieving revision 1.127
> diff -u -p -r1.127 ports.7
> --- ports.7   16 Jun 2019 14:24:42 -0000      1.127
> +++ ports.7   27 Apr 2020 08:19:41 -0000
> @@ -620,10 +620,24 @@ try to use as options to
>  .Xr pkg_add 1
>  to install the missing packages from

If you want, you can say "to install any missing packages from"
because the idea of missing packages wasn't introduced earlier,
so the definite article may not be ideal.

>  .Ev PKG_PATH .
> -For instance:
> +.Xr bsd.port.mk 5
> +does not set
> +.Ev FETCH_PACKAGES ,
> +so even an empty value amounts to setting the variable.
> +.Pp
> +For instance, to run
> +.Nm pkg_add

Please make this line

  .Xr pkg_add 1

because "pkg_add" is not the topic of the present manual page, ports(7).
Repeated .Xrs to the same target are not a problem.

> +with default options
> +.Pc :

These two lines should be one:

  with default options:

>  .Bd -literal -offset indent
> -make FETCH_PACKAGES=
> +make FETCH_PACKAGES= 

Please do not add trailing whitespace.

>  .Ed
> +.Pp
> +or, to enforce the snapshots directory during the final beta period:

Here, i suggest saying "to enforce using the snapshots directory",
or, maybe even better, "to use the snapshots directory".

> +.Bd -literal -offset indent
> +make FETCH_PACKAGES=-Dsnap
> +.Ed
> +.Pp

Please delete this .Pp, it is redundant before .It in a non-compact list.

>  .It Ev PATCH_DEBUG
>  If defined, display verbose output when applying each patch.
>  .It Ev INTERACTIVE

Reply via email to