I'm not sure if this is the right approach, but `make fake' with
MAKE_JOBS set (in mk.conf) fails:

        $ make fake
        ...
        /bin/sh: -j4: not found

That is because ALL_FAKE_FLAGS (usually put after MAKE_PROGRAM) is used
in do-install, but as environment setup:

        $ make -p | grep -e ^PARALLEL_MAKE_FLAGS -e FAKE_FLAGS
        ALL_FAKE_FLAGS   = ${MAKE_FLAGS:N-j[0-9]*} ${DESTDIRNAME}=${WRKINST} 
${FAKE_FLAGS} ${PARALLEL_MAKE_FLAGS}
        FAKE_FLAGS       = HOME=${WKRDIR}/home
        PARALLEL_MAKE_FLAGS = -j${MAKE_JOBS}
                  @cd ${WRKSRC} && ${ALL_FAKE_FLAGS} ${RUBY} install.rb  
--vardir=${LOCALSTATEDIR}/db/puppet/cache/  
--rundir=${LOCALSTATEDIR}/run/puppetlabs/  
--localedir=${TRUEPREFIX}/${MODRUBY_SITEDIR}/puppet/locales


I think FAKE_FLAGS should be used here instead;  it at least fixes
picking up MAKE_JOBS eventually.

Thoughts?


Index: 4/Makefile
===================================================================
RCS file: /cvs/ports/sysutils/ruby-puppet/4/Makefile,v
retrieving revision 1.35
diff -u -p -r1.35 Makefile
--- 4/Makefile  16 Apr 2020 13:59:04 -0000      1.35
+++ 4/Makefile  18 Apr 2020 22:34:27 -0000
@@ -21,7 +21,7 @@ pre-install:
                ${WRKSRC}/ext/rack/config.ru
 
 do-install:
-       @cd ${WRKSRC} && ${ALL_FAKE_FLAGS} ${RUBY} install.rb \
+       @cd ${WRKSRC} && ${FAKE_FLAGS} ${RUBY} install.rb \
                --vardir=${LOCALSTATEDIR}/db/puppet/cache/ \
                --rundir=${LOCALSTATEDIR}/run/puppetlabs/ \
                --localedir=${TRUEPREFIX}/${MODRUBY_SITEDIR}/puppet/locales
Index: 5/Makefile
===================================================================
RCS file: /cvs/ports/sysutils/ruby-puppet/5/Makefile,v
retrieving revision 1.23
diff -u -p -r1.23 Makefile
--- 5/Makefile  18 Mar 2020 18:39:17 -0000      1.23
+++ 5/Makefile  18 Apr 2020 22:32:49 -0000
@@ -22,7 +22,7 @@ pre-install:
                ${WRKSRC}/ext/rack/config.ru
 
 do-install:
-       @cd ${WRKSRC} && ${ALL_FAKE_FLAGS} ${RUBY} install.rb \
+       @cd ${WRKSRC} && ${FAKE_FLAGS} ${RUBY} install.rb \
                --vardir=${LOCALSTATEDIR}/db/puppet/cache/ \
                --rundir=${LOCALSTATEDIR}/run/puppetlabs/ \
                 --localedir=${TRUEPREFIX}/${MODRUBY_SITEDIR}/puppet/locales/

Reply via email to