On Fri, Mar 13, 2020 at 07:17:39PM +0100, Caspar Schutijser wrote: > Hi, > > Below is a patch that updates Tor Browser to 9.0.6. Briefly tested on > amd64.
Thanks, commited ! > Note that I'm also removing aarch64 from ONLY_FOR_ARCHS. With the > recent big update of Tor Browser, I figured I would add aarch64 to see > what would happen (given that I do not have such a machine myself). > However, the aarch64 ports build logs [1] show that the bundled copy > of nspr is causing the build to fail. I see (at least) two options here: > 1) we use nspr from devel/nspr; *however*, a comment in > tor-browser/browser/Makefile mentions that we "need" to use the bundled > nss, sqlite (and I assume nspr too). I don't know yet why that is the > case. If we really need the bundled nspr, we could ... > 2) apply the patches from devel/nspr to this port too. I would like > to avoid this if possible. I dont think you really have the choice here, as iirc tbb patches the bundled nspr so you *have* to use the bundled copy, thus reapply needed patches from the devel/nspr port, unless such patches are merged upstream in a release and tbb updates its local copy of it. > But until then, Tor Browser is not buildable on aarch64. I would not > mind at all if someone interested in aarch64 support for this port > takes a look at this before I get a chance to do it :) 100% agreed, this is a job for someone caring about having it running on arm64. any takers ?
