On Thu, 05 Mar 2020 at 23:28:50 +0000, Edd Barrett wrote:
> Hi,
>
> This is a golang implementation of magic wormhole:
> https://github.com/warner/magic-wormhole
>
> The go implementation is easier to port than the Python one ;)
>
> Had to generate a vendored tarball, hence hosting the distfile.
>
> Comments? OK?
>
> --
> Best Regards
> Edd Barrett
>
> http://www.theunixzoo.co.uk
I'd whack the GH_* stuff in favor of ALL_TARGET (doing so breaks the distfile -
i think it just needs to contain a directory named
"wormhole-william-vendored-${V")
For go apps GH_* sets ALL_TARGET which then becomes:
go install ${ALL_TARGET}
I prefer just setting ALL_TARGET as it's a bit more clear what's happening and
makes the makefile a bit shorter (also I have a mental twinge from the GH
distfile regen stuff when I see GH_* :P)
MODGO_TYPE is default, so it can be removed.
OK abieber@ with MODGO_TYPE removed - whacking GH_* is up to you :D
--
PGP: 0x1F81112D62A9ADCE / 3586 3350 BFEA C101 DB1A 4AF0 1F81 112D 62A9 ADCE
