Hi,
On Sat, 7 Mar 2020 18:28:44 +0100
Alessandro De Laurenzis wrote:
> Greetings,
>
> The attached diff updates cad/magic to a very recent release.
>
> Please note that this is a big jump, since we're moving from 8.1
> (distribution) branch to 8.2 (development).
>
> The point has been already discussed on this list (see e.g. [1]);
> first of all, let me say that the number of new features and fixes
> from upstream is so high that I strongly suggest to treat this update
> as a new port (and so double check and test it as such).
>
> The main reason why I've been reluctant so far to jump to this branch
> is that I never succeeded in making the Cairo graphics interface
> working on OpenBSD (this, along with the "stable" OpenGL rendering,
> is one of the most relevant addition w.r.t. 8.1.x).
>
> In order to ease the port's test process for non-habitual magic's
> users I've prepared a simple layout (see inv.mag attachment); you
> could also use the tutorial files, but most of them are pretty
> counter-intuitive when you do not follow the various sections.
Thanks for this, really appreciated :)
> So, the normal ("x11") rendering can be seen launching the command:
>
> $ magic inv
>
> For OpenGL rendering, which is much much better:
>
> $ magic -d OGL inv
>
> (do you see the difference? :-) ); Cairo graphics should be fired by:
>
> $ magic -d XR inv
>
> or:
>
> $ magic -d CAIRO inv
>
> but on my Thinkpad T430 with an Intel HD Graphics 4000 I only see a
> black window...
I can confirm that i have the same behaviour on amd64 with
radeondrm(4), with `-d XR' it displays some garbage:
http://0x0.st/iT4q.png
> On the other hand, I think that the Cairo library is playing its role
> correctly when OGL is selected, since without adding the
> "--enable-cairo-offscreen" configure option the toolbar buttons are
> blank or contain random trash bits in this mode.
>
> Any hints on this point are welcome; I'm of course open to
> experiments!
>
> Please also note that this release contains the fix suggested by
> cwen@ (see [2]) for un-breaking the port on gcc-based archs.
> Charlene, could you please double-check and confirm that all is ok?
>
>
> What's new in the port
> ======================
> - updated maintainer email address;
> - we need to add "--with-distdir=${PREFIX}" to CONFIGURE_ARGS (due to
> a recent upstream change related to distributed install);
> - man pages require a post-install tweak to be moved to the right
> place;
> - I added a patch to magic/proto.magicrc to correctly treat the
> comment lines (this should be discussed upstream... sorry, I didn't
> have the time to report it);
> - all the others are trivial updates.
>
>
> Tested on amd64 only.
I've tested on amd64 and macppc (where colors aren't even off!).
This looks good to me.
OK cwen@
> [1] https://marc.info/?l=openbsd-ports&m=155255289309963&w=2
> [2] https://github.com/RTimothyEdwards/magic/issues/8
>
> --
> Alessandro De Laurenzis
> [mailto:jus...@atlantide.mooo.com]
> Web: http://www.atlantide.mooo.com
> LinkedIn: http://it.linkedin.com/in/delaurenzis
