On Tue, Mar 03, 2020 at 10:12:55PM +0000, Stuart Henderson wrote:
> On 2020/03/03 18:16, Rafael Sadowski wrote:
> > On Mon Mar 02, 2020 at 06:09:01PM +0100, Rafael Sadowski wrote:
> > > On Mon Mar 02, 2020 at 03:41:55PM +0100, Landry Breuil wrote:
> > > > On Mon, Mar 02, 2020 at 02:34:05PM +0000, Stuart Henderson wrote:
> > > > > On 2020/02/29 18:38, Landry Breuil wrote:
> > > > > > On Sat, Feb 29, 2020 at 03:51:13PM +0000, Stuart Henderson wrote:
> > > > > > > On 2020/02/29 07:27, Landry Breuil wrote:
> > > > > > > > On Thu, Feb 27, 2020 at 08:48:55AM +0100, Rafael Sadowski wrote:
> > > > >
> > > > > Looking at
> > > > > https://www.riverbankcomputing.com/static/Docs/PyQt5/installation.html
> > > > >
> > > > > "It is not necessary to install the PyQt5.sip module before building
> > > > > PyQt5 but it must be installed before PyQt5 can be used.
> > >
> > > Fu** I missed this in my diff! BIG SORRY
> > >
> > > > >
> > > > > The module is built using setuptools and is available from the
> > > > > PyQt5-sip
> > > > > project at PyPI. It uses setuptools as its build system and can be
> > > > > installed by pip or you can also unpack the sdist and install it by
> > > > > running its setup.py script."
> > > > >
> > > > > So it looks like this should probably be a separate port ..
> > > >
> > > > ah, so its now a separate port, that should be a RUN_DEPENDS for py-qt5
> > > > ? rafael, does it ring a bell to you ?
> > >
> > > Yeah, this is necessary, sorry for missing this in my last diff. It's
> > > hard to painful to create such large diffs!
> > >
> >
> > New diff which includes the missing py-sip bits. Not yet adjusted,
> > landrys py-qt5 diff.
> > +@so lib/python${MODPY_VERSION}/site-packages/PyQt5/sip.so
> > +lib/python${MODPY_VERSION}/site-packages/PyQt5_sip-${MODPY_EGG_VERSION}.dist-info/
> > +lib/python${MODPY_VERSION}/site-packages/PyQt5_sip-${MODPY_EGG_VERSION}.dist-info/INSTALLER
> > +lib/python${MODPY_VERSION}/site-packages/PyQt5_sip-${MODPY_EGG_VERSION}.dist-info/METADATA
> > +lib/python${MODPY_VERSION}/site-packages/PyQt5_sip-${MODPY_EGG_VERSION}.dist-info/RECORD
> > ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}/
> >
> > lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}sipconfig.${MODPY_PYC_MAGIC_TAG}pyc
> >
> > lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}sipdistutils.${MODPY_PYC_MAGIC_TAG}pyc
> > -lib/python${MODPY_VERSION}/site-packages/sip-${MODPY_EGG_VERSION}.dist-info/
> > -lib/python${MODPY_VERSION}/site-packages/sip-${MODPY_EGG_VERSION}.dist-info/INSTALLER
> > -lib/python${MODPY_VERSION}/site-packages/sip-${MODPY_EGG_VERSION}.dist-info/METADATA
> > -lib/python${MODPY_VERSION}/site-packages/sip-${MODPY_EGG_VERSION}.dist-info/RECORD
> > -lib/python${MODPY_VERSION}/site-packages/sip.pyi
> > -@so lib/python${MODPY_VERSION}/site-packages/sip.so
> > lib/python${MODPY_VERSION}/site-packages/sipconfig.py
> > lib/python${MODPY_VERSION}/site-packages/sipdistutils.py
> > share/doc/${MODPY_PY_PREFIX}sip/
>
> This looks wrong. py-qt5 is not the only thing using py-sip, I think you
> need either a separate port or a flavour for this.
i had a hard time wrapping my head around this, and i agree with stuart
here. adding --sip-module somewhat renames the python sip module to
PyQt5_sip, which might not be what sip consumers expect, ie at least the
ones via x11/py-qt4 which depends on the python2 py-sip. Building py-qt4
here with the diff, but it would rather require runtime testing with
consmers, or import tests via a python cli, etc. only building is not
enough.
an option would be to use --sip-module only in the python3 flavor
for py-sip, since py-qt5 is the only consumer. but that would require a
bit more SUBST work in the py-sip port. will eventually try.
> PFRAG.python3 is not needed, these entries were fine how they were
> in PLIST with the ${MODPY_COMMENT} prefix.
100% agree
> Question: does the *existing* py-qt5 work with the new x11/qt5 pieces?
Sadly, i really doubt so.. but only runtime testing would tell.. such a
huge runtime testing matrix.. with tightly coupled version
dependencies..
Landry
