Python 3 is required at build time, but only for one specific command.
As per the diff below, I'd like to use it as regular module, but
loccount seems special and the diff does not work as it since
python.port.mk executes MODPY_BUILD_TARGET because CONFIGURE_STYLE is empty
*and* the do-build target is not set.

What is the sanest approach here?
Add lang/python as BDEP and be done with it just like lang/go?
Fix python.port.mk to be more sensitive?


Index: Makefile
===================================================================
RCS file: /cvs/ports/textproc/loccount/Makefile,v
retrieving revision 1.7
diff -u -p -r1.7 Makefile
--- Makefile    12 Feb 2020 21:27:27 -0000      1.7
+++ Makefile    3 Mar 2020 17:51:36 -0000
@@ -21,6 +21,11 @@ MASTER_SITES =               https://gitlab.com/esr/l
 DISTFILES =            ${DISTNAME}{${V}/archive}${EXTRACT_SUFX}
 WRKDIST =              
${WRKDIR}/${DISTNAME}-637e87621156d494919e6738748291018e54aa28
 
+MODULES =              lang/python
+MODPY_VERSION =                ${MODPY_DEFAULT_VERSION_3}
+MODPY_RUNDEP =         No
+MODPY_ADJ_FILES =      tablegen.py
+
 BUILD_DEPENDS =                lang/go \
                        textproc/asciidoc
 


Here's the full build failure, FWIW.  Thanks naddy!


On Mon, Mar 02, 2020 at 07:11:04PM +0100, Christian Weisgerber wrote:
> >>> Building on amd64-3 under textproc/loccount
>        BDEPENDS = [lang/go;textproc/asciidoc]
>        DIST = [textproc/loccount:loccount-2.9.tar.gz]
>        FULLPKGNAME = loccount-2.9
> (Junk lock obtained for amd64-3 at 1583106117.69)
> >>> Running depends in textproc/loccount at 1583106117.75
>    last junk was in databases/ruby-pg,ruby25
> /usr/sbin/pkg_add -aI -Drepair asciidoc-8.6.9p1 go-1.13.7p0
> was: /usr/sbin/pkg_add -aI -Drepair asciidoc-8.6.9p1 go-1.13.7p0
> /usr/sbin/pkg_add -aI -Drepair asciidoc-8.6.9p1 go-1.13.7p0
> >>> Running show-prepare-results in textproc/loccount at 1583106125.26
> ===> textproc/loccount
> ===> loccount-2.9 depends on: go-=1.13.7p0 -> go-1.13.7p0
> ===> loccount-2.9 depends on: asciidoc-* -> asciidoc-8.6.9p1
> ===>  Verifying specs:  c pthread
> ===>  found c.96.0 pthread.26.1
> asciidoc-8.6.9p1
> go-1.13.7p0
> Still tainted: no
> >>> Running junk in textproc/loccount at 1583106125.86
> /usr/sbin/pkg_delete -aIXq arm-none-eabi-binutils-2.27p0 asciidoc-8.6.9p1 
> autoconf-2.13p4 autoconf-2.69p2 bison-3.3.2p1 curl-7.68.0 flac-1.3.3 
> gd-2.2.5p1 gmake-4.3 go-1.13.7p0 jpeg-2.0.4p0v0 libexif-0.6.21p3 
> libltdl-2.4.2p1 libmpc-1.1.0 libusb-compat-0.1.5p0 libxml-2.9.10p0 lua-5.3.5 
> metaauto-1.0p3 mpfr-4.0.2.1 python-2.7.17p1 sdl2-2.0.10p0 sdl2-ttf-2.0.14p0 
> sqlite3-3.31.1 xz-5.2.4p0
> --- -avahi-0.8 -------------------
> You should also run /usr/sbin/userdel _avahi
> You should also run /usr/sbin/groupdel _avahi
> --- -cups-libs-2.3.1 -------------------
> You should also run /usr/sbin/userdel _cups
> You should also run /usr/sbin/groupdel _cups
> --- -cyrus-sasl-2.1.27p1 -------------------
> You should also run rm -rf /var/sasl2/*
> --- -dbus-1.12.16p0v0 -------------------
> You should also remove /etc/machine-id
> You should also run /usr/sbin/userdel _dbus
> You should also run /usr/sbin/groupdel _dbus
> --- -ghostscript-fonts-8.11p3 -------------------
> You may wish to remove /usr/local/share/fonts/ghostscript from your font path
> --- -jdk-1.8.0.242.b07.1v0 -------------------
> You may wish to remove /usr/local/jdk-1.8.0/man from man.conf
> --- -libmaxminddb-1.4.2p0 -------------------
> You should also run rm /var/db/GeoIP/*
> --- -qt3-mt-3.8p19 -------------------
> You may wish to remove /usr/local/lib/qt3/man from man.conf
> --- -ruby-2.5.7p1 -------------------
> If you set up the symlinks to make ruby 2.5 the system
> ruby, don't forget to remove the following files:
> 
>  rm /usr/local/bin/ruby
>  rm /usr/local/bin/erb
>  rm /usr/local/bin/irb
>  rm /usr/local/bin/rdoc
>  rm /usr/local/bin/ri
>  rm /usr/local/bin/gem
>  rm /usr/local/bin/rake
> --- -ruby-2.6.5p1 -------------------
> If you set up the symlinks to make ruby 2.6 the system
> ruby, don't forget to remove the following files:
> 
>  rm /usr/local/bin/ruby
>  rm /usr/local/bin/erb
>  rm /usr/local/bin/irb
>  rm /usr/local/bin/rdoc
>  rm /usr/local/bin/ri
>  rm /usr/local/bin/gem
>  rm /usr/local/bin/bundle
>  rm /usr/local/bin/bundler
>  rm /usr/local/bin/rake
> --- -tcl-8.5.19p4 -------------------
> You may wish to remove /usr/local/lib/tcl/tcl8.5/man from man.conf
> --- -tcl-8.6.8p2 -------------------
> You may wish to remove /usr/local/lib/tcl/tcl8.6/man from man.conf
> --- -tk-8.5.19p1 -------------------
> You may wish to remove /usr/local/lib/tcl/tk8.5/man from man.conf
> (Junk lock released for amd64-3 at 1583106141.85)
> distfiles size=69780
> >>> Running build in textproc/loccount at 1583106141.92
> ===> textproc/loccount
> ===>  Checking files for loccount-2.9
> `/usr/ports/distfiles/loccount-2.9.tar.gz' is up to date.
> >> (SHA256) loccount-2.9.tar.gz: OK
> ===>  Extracting for loccount-2.9
> ===>  Patching for loccount-2.9
> ===>  Compiler link: clang -> /usr/bin/clang
> ===>  Compiler link: clang++ -> /usr/bin/clang++
> ===>  Compiler link: cc -> /usr/bin/cc
> ===>  Compiler link: c++ -> /usr/bin/c++
> ===>  Generating configure for loccount-2.9
> ===>  Configuring for loccount-2.9
> ===>  Building for loccount-2.9
> go generate
> env: python3: No such file or directory
> loccount.go:4: running "./tablegen.py": exit status 127
> *** Error 1 in 
> /usr/obj/ports/loccount-2.9/loccount-2.9-637e87621156d494919e6738748291018e54aa28
>  (Makefile:7 'loccount')
> *** Error 2 in textproc/loccount 
> (/usr/ports/infrastructure/mk/bsd.port.mk:2890 
> '/usr/obj/ports/loccount-2.9/.build_done': @cd /usr/obj/port...)
> *** Error 2 in textproc/loccount 
> (/usr/ports/infrastructure/mk/bsd.port.mk:2556 'build': @lock=loccount-2.9;  
> export _LOCKS_HELD=" loccount-...)
> ===> Exiting textproc/loccount with an error
> *** Error 1 in /usr/ports (infrastructure/mk/bsd.port.subdir.mk:137 'build': 
> @: ${echo_msg:=echo};  : ${target:=build};  for i in ; do  eval...)
> >>> Ended at 1583106142.34
> Error: job failed with 512 on amd64-3 at 1583106142

Reply via email to