On Thu 20/02/2020 13:55, Stuart Henderson wrote: > Quite a few python modules are now py3-only, and more are switching > over to that. The current ports setup where we use MODPY_VERSION= > ${MODPY_DEFAULT_VERSION_3} and no FLAVOR isn't really very good, > especially where dependencies are concerned with the error-prone > combination of "py2+3 ports using ${MODPY_FLAVOR}" and "py3-only > ports with just the port path/name". > > Before more are moved across I'd like to settle on a proper method. > I've been discussing this with jasper@ (with some previous knowledge > from adding a similar multi-version to pecl-* ports) and propose moving > to a setup with: > > FLAVOR= python3 > FLAVORS= python3 > > (and keep the ,python3 flavour in ../Makefile i.e. "SUBDIR += > py-Foo,python3"). > This also makes it easier to handle updates as we don't need to mess about > with @pkgpath markers.
Sounds like a plan... What about lines in Makefile like the one below. Does it make sense to keep them around? There is no need to add a suffix to scripts in the case of py3-only. mv ${PREFIX}/bin/$i{,${MODPY_BIN_SUFFIX}} > Obviously there are currently a number of py3-only ports which should end > up using the same flavour scheme (and dependency lines to fix), if there are > not objections I can either review diffs or take care of those myself. I'm not sure what is needed for ports that already made the jump from py2/py3 to py3-only (e.g. www/jupyter-notebook). More specific: these ports already do some funky PLIST and quirks stuff. Do these ports need special attention?