Hi,

smtube uses the website tonvid.com but it uses http:// by default, this patch
will make it use https://tonvid.com instead.

(and a crash report below the patch)


Index: Makefile
===================================================================
RCS file: /data/cvs/ports/x11/smtube/Makefile,v
retrieving revision 1.35
diff -u -p -r1.35 Makefile
--- Makefile    15 Jul 2019 13:21:51 -0000      1.35
+++ Makefile    19 Feb 2020 10:30:13 -0000
@@ -5,6 +5,7 @@ USE_WXNEEDED =          Yes
 COMMENT =              browse and download YouTube videos
 
 DISTNAME =             smtube-19.6.0
+REVISION =             0
 
 CATEGORIES =           multimedia x11
 
Index: patches/patch-src_browserwindow_cpp
===================================================================
RCS file: patches/patch-src_browserwindow_cpp
diff -N patches/patch-src_browserwindow_cpp
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_browserwindow_cpp 19 Feb 2020 10:30:02 -0000
@@ -0,0 +1,23 @@
+$OpenBSD$
+
+Index: src/browserwindow.cpp
+--- src/browserwindow.cpp.orig
++++ src/browserwindow.cpp
+@@ -70,7 +70,7 @@ BrowserWindow::BrowserWindow(const QString & config_pa
+ {
+       setWindowTitle("SMTube");
+       setWindowIcon(QPixmap(":/icons/smtube.png"));
+-      home_page = "http://www.tonvid.com/";;
++      home_page = "https://www.tonvid.com/";;
+ 
+       settings = new QSettings(config_path + "/smtube2.ini", 
QSettings::IniFormat, this);
+ 
+@@ -442,7 +442,7 @@ void BrowserWindow::openYTUrl(QString title, QString e
+       if (current_player == WebBrowser) {
+               QString u = url;
+               #if 1
+-              u = "http://www.tonvid.com/video.php?u="; + 
url.toUtf8().toBase64().toPercentEncoding() +
++              u = "http://wwws.tonvid.com/video.php?u="; + 
url.toUtf8().toBase64().toPercentEncoding() +
+             "&t=" + title.toUtf8().toBase64().toPercentEncoding();
+               #endif
+               QDesktopServices::openUrl(u);




When I exit smtube, it crashes every time, here is egdb backtrace output.
This happen on -current with up to date packages.

[New process 212199]
[New process 440316]
[New process 346182]
[New process 366883]
[New process 547468]
[New process 186961]
[New process 189499]
[New process 558678]
[New process 462303]
bt
Core was generated by `smtube'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000006391b8994e2 in std::__1::__atomic_base<int, 
false>::load(std::__1::memory_order) const () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
[Current thread is 1 (process 212199)]
(gdb) bt
#0  0x000006391b8994e2 in std::__1::__atomic_base<int, 
false>::load(std::__1::memory_order) const () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#1  0x000006391b899471 in int QAtomicOps<int>::load<int>(std::__1::atomic<int> 
const&) () from /usr/local/lib/qt5/libQt5Core.so.2.2
#2  0x000006391b89942f in QBasicAtomicInteger<int>::load() const () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#3  0x000006391b8992f6 in QtPrivate::RefCount::deref() () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#4  0x000006391b8a6e5c in QString::~QString() () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#5  0x000006391bc91ad2 in void v_clear<QString>(QVariant::Private*, QString*) 
() from /usr/local/lib/qt5/libQt5Core.so.2.2
#6  0x000006391bc79d2a in QVariantDestructor<(anonymous 
namespace)::CoreTypesFilter>::FilteredDestructor<QString, 
true>::FilteredDestructor(QVariant::Private*) () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#7  0x000006391bc7859d in void QVariantDestructor<(anonymous 
namespace)::CoreTypesFilter>::delegate<QString>(QString const*) () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#8  0x000006391bc77a79 in void QMetaTypeSwitcher::switcher<void, 
QVariantDestructor<(anonymous namespace)::CoreTypesFilter> 
>(QVariantDestructor<(anonymous namespace)::CoreTypesFilter>&, int, void 
const*) ()
   from /usr/local/lib/qt5/libQt5Core.so.2.2
#9  0x000006391bc6f5db in (anonymous namespace)::clear(QVariant::Private*) () 
from /usr/local/lib/qt5/libQt5Core.so.2.2
#10 0x000006391bc64b54 in QVariant::~QVariant() () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#11 0x000006391bb1375f in QMapNodeBase::callDestructorIfNecessary<QVariant> () 
from /usr/local/lib/qt5/libQt5Core.so.2.2
#12 0x000006391bb13c10 in QMapNode<QSettingsKey, QVariant>::destroySubTree() () 
from /usr/local/lib/qt5/libQt5Core.so.2.2
#13 0x000006391bb13c9d in QMapNode<QSettingsKey, 
QVariant>::doDestroySubTree(std::__1::integral_constant<bool, true>) () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#14 0x000006391bb13c19 in QMapNode<QSettingsKey, QVariant>::destroySubTree() () 
from /usr/local/lib/qt5/libQt5Core.so.2.2
#15 0x000006391bb13c9d in QMapNode<QSettingsKey, 
QVariant>::doDestroySubTree(std::__1::integral_constant<bool, true>) () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#16 0x000006391bb13c19 in QMapNode<QSettingsKey, QVariant>::destroySubTree() () 
from /usr/local/lib/qt5/libQt5Core.so.2.2
#17 0x000006391bb13c9d in QMapNode<QSettingsKey, 
QVariant>::doDestroySubTree(std::__1::integral_constant<bool, true>) () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#18 0x000006391bb13c19 in QMapNode<QSettingsKey, QVariant>::destroySubTree() () 
from /usr/local/lib/qt5/libQt5Core.so.2.2
#19 0x000006391bb13c9d in QMapNode<QSettingsKey, 
QVariant>::doDestroySubTree(std::__1::integral_constant<bool, true>) () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#20 0x000006391bb13c19 in QMapNode<QSettingsKey, QVariant>::destroySubTree() () 
from /usr/local/lib/qt5/libQt5Core.so.2.2
#21 0x000006391bb13c9d in QMapNode<QSettingsKey, 
QVariant>::doDestroySubTree(std::__1::integral_constant<bool, true>) () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#22 0x000006391bb13c19 in QMapNode<QSettingsKey, QVariant>::destroySubTree() () 
from /usr/local/lib/qt5/libQt5Core.so.2.2
#23 0x000006391bb13c9d in QMapNode<QSettingsKey, 
QVariant>::doDestroySubTree(std::__1::integral_constant<bool, true>) () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#24 0x000006391bb13c19 in QMapNode<QSettingsKey, QVariant>::destroySubTree() () 
from /usr/local/lib/qt5/libQt5Core.so.2.2
#25 0x000006391bb13c9d in QMapNode<QSettingsKey, 
QVariant>::doDestroySubTree(std::__1::integral_constant<bool, true>) () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#26 0x000006391bb13c19 in QMapNode<QSettingsKey, QVariant>::destroySubTree() () 
from /usr/local/lib/qt5/libQt5Core.so.2.2
#27 0x000006391bb13b41 in QMapData<QSettingsKey, QVariant>::destroy() () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#28 0x000006391bb0e750 in QMap<QSettingsKey, QVariant>::~QMap() () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#29 0x000006391bb0026d in QConfFile::~QConfFile() () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#30 0x000006391bb0f011 in QCache<QString, QConfFile>::clear() () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#31 0x000006391bb14e26 in QCache<QString, QConfFile>::~QCache() () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#32 0x000006391bb0db16 in (anonymous 
namespace)::Q_QGS_unusedCacheFunc::innerFunction()::Holder::~Holder() () from 
/usr/local/lib/qt5/libQt5Core.so.2.2
#33 0x000006396fc3edcd in _libc___cxa_finalize (dso=<optimized out>) at 
/usr/src/lib/libc/stdlib/atexit.c:177
#34 0x000006396fc27231 in _libc_exit (status=0) at 
/usr/src/lib/libc/stdlib/exit.c:54
#35 0x000006369c3a7142 in ___start ()
#36 0x0000000000000000 in ?? ()

Reply via email to