On Wed, Feb 12, 2020 at 09:02:08PM +0100, Caspar Schutijser wrote:
> On Wed, Feb 12, 2020 at 03:22:04PM +0100, clematis wrote:
> > On Wed, Feb 12, 2020 at 10:54:19AM +0100, Landry Breuil wrote:
> > > On Wed, Feb 12, 2020 at 07:30:22AM +0100, clematis wrote:
> > > > On Tue, Feb 11, 2020 at 10:12:20PM +0100, Caspar Schutijser wrote:
> > > > > On Tue, Feb 11, 2020 at 03:23:03PM +0100, Landry Breuil wrote:
> > > > > > On Sat, Jan 11, 2020 at 03:43:06PM +0100, Caspar Schutijser wrote:
> > > > > > > On Fri, Jan 10, 2020 at 10:31:15AM +0000, Stuart Henderson wrote:
> > > > > > > > On 2019/12/28 09:07, Caspar Schutijser wrote:
> > > ok good, it's just that in mozilla land, build1 is "first release
> > > candidate", that's all - cf
> > > of course TB-browser might not use the same convention :)
> >
> > FYI, here is the reply from Nicolas Vigier (@boklm torproject):
> >
> > === 8< ===
> > The naming convention is based on the git tag we are using:
> >
> > src-firefox-tor-browser-${firefox_version}-${torbrowser_branch}-${n}-build${m}
> >
> > ${n} is a number that we increase if we rebase our patches. Usually we
> > don't rebase them on the same firefox version, so most of the time it
> > is '1'.
> >
> > ${m} is a number that we increase when we added new patches. A -build2
> > for example indicates that we did a first build, then added new patches
> > and did a second build (however only the last one is uploaded to
> > dist.tpo).
> > === 8< ===
> >
> > Also note that:
> > Release Candidates are uploaded under the ~/ of whoever is building it.
> > There should always be only one firefox source tarball for each Tor
> > Browser version on dist.tpo.
> >
> > Caspar, if you are interested in this, Nicolas offered to send an email
> > out when they have a Release Candidate if you want to test build before
> > it gets released.
> >
> > His complete email reply to tbb-dev:
> > https://lists.torproject.org/pipermail/tbb-dev/2020-February/001046.html
>
> Thanks for clearing that up and also for making sure it still builds
> with Rust 1.41. For now, it is not necessary for me to receive an email
> about release candidates.
>
> Regarding Tor Browser 9.0.5, I'll probably send a diff for that during
> the weekend.
In the meantime i've commited the 9.0.4 update, after all its been
waiting since last year... some minor nits after the fact (that you can
address in the 9.0.5 update):
- usr/local shouldnt be hardcoded in
patch-browser_extensions_tor-launcher_src_defaults_preferences_torlauncher-prefs_js,
usually you patch with ${LOCALBASE} and then use ${SUBST_CMD} in
post-patch to set the 'real' value.
- from my understanding this will enable the pledge codepaths, or not ?
i didnt see anything configuring pledge strings (as it was in 72 that
they moved to files)
- i suppose you blindly added patch-config_system-headers_mozbuild to
give a chance to arm64 to build ?
besides that, thanks for the hard work ! I think (if you want so) you
should take maintainership for this port so that it gets updates.. sean,
can you at least acknowledge this mail ?
Landry
>
> Thanks,
> Caspar Schutijser
>
