On Fri Feb 07, 2020 at 10:31:26PM +0100, Charlene Wendling wrote: > Hi, > > On Thu, 6 Feb 2020 21:45:47 +0100 > Rafael Sadowski wrote: > > > Hi ports@, > > > > Ninja 0.10.0 was released a while ago. Here is a link to the notes: > > > > https://groups.google.com/forum/#!msg/ninja-build/piOltAhywFA/zPfkrTtRCwAJ > > > > The new version comes with Fortran support. Maybe we can finally get > > rid of all the "USE_NINJA=No". This is a job for someone who's > > interested. Volunteers come forward :) > > > > This diff needs a hand full of OKs from persons in charge of the > > bulks. > > Ninja is built with ports-gcc on base-gcc archs, but i've found that > the environment is not passed in the "do-test" hook, so tests are built > with base-gcc, and fail with: > > cc1plus: error: unrecognized command line option "-fdiagnostics-color" > > I've tweaked your Makefile diff to pass the test environment. > > On powerpc, it builds and tests are passing [0]. I can't test bulk on > macppc within a reasonable timeframe, but i'll fix stuff with it, so > i'll report back if any issue arise. > > Charlène. > > > [0] https://bin.charlenew.xyz/ninja.powerpc.log > > > do-test: > - @cd ${WRKSRC} && ./ninja ninja_test \ > + @cd ${WRKSRC} && ${SETENV} ${ALL_TEST_ENV} ./ninja ninja_test \ > && ./ninja_test --gtest_filter=MyTest.Name > > .include <bsd.port.mk> > Index: distinfo
I would suggest that we go in with the test fix. OK rsadowski
