On Sat, 01 Feb 2020 at 03:29:25 -0500, Raymond E. Pasco wrote:
> - I used a modified distfile provided by abieber with a vendor directory,
> which is necessary due to the large number of go package dependencies.
>
> - The custom version of go-libvterm used by aerc upstream includes an
> (unmodified) bundled copy of libvterm itself, which causes issues with
> the build. I instead link against devel/libvterm.
>
> - One filter script shipped with aerc (to display HTML email) depends on
> socksify (provided by security/dante) and www/w3m. I did not include these
> as RUN_DEPENDS because this is an optional script disabled by default,
> but I'm not sure whether this approach is correct.
>
> - cgo in go 1.13 (but not go 1.14) considers ~ an invalid path character,
> but the top-level package name here (and therefore WRKSRC) contains an ~.
> I remedied this by moving the vendor directory contents up to the level
> of the MODGO_WORKSPACE. This workaround shouldn't be necessary when go
> 1.14 is released.
>
> - aerc can be built with notmuch support, but notmuch isn't in ports (yet?),
> so I didn't bother with this.
It looks good to me. I'd like to pass in MODGO_FLAGS so we can have verbose
info when DEBUG is set. Something like:
MAKE_ENV += GOFLAGS="${MODGO_FLAGS}"
But it seems the "-p ${MAKE_JOBS}" bit from go.port.mk isn't getting parsed
properly in this case.
Anyway, if that bit can be sorted out, OK abieber@ for import!
--
PGP: 0x1F81112D62A9ADCE / 3586 3350 BFEA C101 DB1A 4AF0 1F81 112D 62A9 ADCE
