On Tue 04/02/2020 09:37, Edd Barrett wrote:
> Hi,
> 
> Here's an update to gophernicus-3.0.1.
> 
> Notes:
> 
>  - I had to switch to GH_* as the old download URL no longer hosts
>    tarballs, and I was unable to get a tarball from github itself.
>    However, I'd appreciate it if someone could check the latter.

Some comments:
- DISTNAME can be removed as it is correctly set by GH_*
- Version (V) can be added to GH_TAGNAME, i.e. GH_TAGNAME=v3.0.1
- GH_* should be placed higher up in Makefile. See Makefile.template.

Something like:

diff --git Makefile Makefile
index eb7307ea140..54679849bc5 100644
--- Makefile
+++ Makefile
@@ -1,11 +1,15 @@
 # $OpenBSD: Makefile,v 1.18 2019/07/12 20:48:27 sthen Exp $
 
 COMMENT=       modern gopher server
-DISTNAME=      gophernicus-2.5
+
+GH_ACCOUNT=    gophernicus
+GH_PROJECT=    gophernicus
+GH_TAGNAME=    v3.0.1
+
 CATEGORIES=    net
-REVISION=      0
 
 HOMEPAGE=      gopher://gophernicus.org/
+
 MAINTAINER =   Brian Callahan <[email protected]>
 
 # BSD
@@ -13,17 +17,15 @@ PERMIT_PACKAGE=     Yes
 
 WANTLIB += c
 
-MASTER_SITES=  http://gophernicus.org/software/gophernicus/
-
 MAKE_FLAGS=    CC="${CC}" CFLAGS="${CFLAGS}"
 NO_TEST=       Yes
 
 do-install:
-       ${INSTALL_PROGRAM} ${WRKSRC}/in.gophernicus ${PREFIX}/libexec
+       ${INSTALL_PROGRAM} ${WRKSRC}/gophernicus 
${PREFIX}/libexec/in.gophernicus
        ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/gophernicus
        ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/gophernicus
-       cd ${WRKSRC} && ${INSTALL_DATA} LICENSE README INSTALL \
-           TODO ChangeLog README.Gophermap gophertag \
+       cd ${WRKSRC} && ${INSTALL_DATA} LICENSE README INSTALL.md \
+           TODO README.Gophermap gophertag \
            ${PREFIX}/share/doc/gophernicus/
        cd ${WRKSRC} && ${INSTALL_DATA} gophermap \
            ${PREFIX}/share/examples/gophernicus/
diff --git distinfo distinfo
index f4c422a822d..24f42e912ce 100644
--- distinfo
+++ distinfo
@@ -1,2 +1,2 @@
-SHA256 (gophernicus-2.5.tar.gz) = ZRu3ZzJhrVUCKAPypMJUiu+ohiojIM301kwyEinl1Zo=
-SIZE (gophernicus-2.5.tar.gz) = 51710
+SHA256 (gophernicus-3.0.1.tar.gz) = 
Fl/SrU+wY430FHFJa7rGgiA6FdBdX3RhiFhYFyE4vJY=
+SIZE (gophernicus-3.0.1.tar.gz) = 52525
diff --git pkg/PLIST pkg/PLIST
index 849fd6008e0..97a3357f436 100644
--- pkg/PLIST
+++ pkg/PLIST
@@ -3,8 +3,7 @@
 @newuser _gophernicus:704:704:daemon:Gophernicus Gopher 
Server:/nonexistent:/sbin/nologin
 @bin libexec/in.gophernicus
 share/doc/gophernicus/
-share/doc/gophernicus/ChangeLog
-share/doc/gophernicus/INSTALL
+share/doc/gophernicus/INSTALL.md
 share/doc/gophernicus/LICENSE
 share/doc/gophernicus/README
 share/doc/gophernicus/README.Gophermap

Reply via email to