On 2020/02/01 19:10, Klemens Nanni wrote: > On Sun, Jan 26, 2020 at 01:07:26PM +0100, Klemens Nanni wrote: > > Python's kitchen sink exists as package; I need this for another, more > > existential port. > > > > Upstream's test consists of a messy bash script that checks Python's > > version at runtime and executes different paths based on that. > > > > The consumer I'm running work fine and I don't want to sink any more > > > > time in such regress suites, so I'd like to leave them as is (for now). > > > > Feedback? OK? > > > > Information for inst:py3-kitchen-1.2.6 > > > > Comment: > > kitchen contains a cornucopia of useful code > > > > Required by: > > tuir-1.28.3 > > > > Description: > > We've all done it. In the process of writing a brand new application we've > > discovered that we need a little bit of code that we've invented before. > > Perhaps it's something to handle unicode text. Perhaps it's something > > to make > > a bit of python-2.5 code run on python-2.3. Whatever it is, it ends up > > being > > a tiny bit of code that seems too small to worry about pushing into its own > > module so it sits there, a part of your current project, waiting to be cut > > and > > pasted into your next project. And the next. And the next. And since > > that > > little bittybit of code proved so useful to you, it's highly likely that it > > proved useful to someone else as well. Useful enough that they've > > written it > > and copy and pasted it over and over into each of their new projects. > > > > Maintainer: The OpenBSD ports mailing-list <ports@openbsd.org> > > > > WWW: https://fedorahosted.org/kitchen > Here's a new tarball that drops flavors and uses Python 3 only, just in > case that's preferred. I've also replaced tabs in DESCR with two spaces.
comments from my previous review still apply; ----- Forwarded message from Stuart Henderson <s...@spacehopper.org> ----- From: Stuart Henderson <s...@spacehopper.org> Date: Tue, 28 Jan 2020 22:12:23 +0000 To: ports@openbsd.org Subject: Re: NEW: www/tuir Mail-Followup-To: ports@openbsd.org On 2020/01/28 22:34, Klemens Nanni wrote: > Here's a Reddit client for your terminal. From time to time it's nice > to browse your favourite subreddit in a terminal^Wenvironment of your > choice instead of a webbrowser. > > This port requires the recent devel/py-kitchen submission to work, > otherwise it just works for me. > > tuir is surprisingly versatile and useful: I could browse through > subreddits and have it open videos, images and audio through available > applications such as mpv and feh -- based on ~/.mailcap for which this > port provides an excellent example. > > I don't have a reddit account so I cannot test login/post/etc. > > All tests pass except those that require networking. > > Since upstream's description^README.md is full of everything but a sound > paragraph about what tuir is/does, I've wipped up the four-liner below. > > > Feedback? OK? > > Information for inst:tuir-1.28.3 > > Comment: > terminal UI for Reddit > > Description: > A text-based interface (TUI) to view and interact with Reddit > from your terminal. > > tuir supports mailcap for opening media links, color schemes, user login and > persistent authentication; all with extensive examples and documentation. > > Maintainer: Klemens Nanni <k...@openbsd.org> > > WWW: https://gitlab.com/ajak/tuir py-kitchen: - HOMEPAGE is dead, it's a toss-up between the github page which is current but not very useful (https://github.com/fedora-infra/kitchen) or https://pythonhosted.org/kitchen/ which is terribly out of date but does actually have some readable docs. - DESCR is not very informative. It could do with at least saying the types of things the functions deal with (i18n, iterating over objects, miscellaneous functions to deal with text and character set conversion).. tuir: one nit otherwise ok once kitchen is in: > tuir supports mailcap for opening media links, color schemes, user login and > persistent authentication; all with extensive examples and documentation. at first glance it reads like "mailcap for: opening media links, color schemes, user login and persistent authentication" which doesn't make sense. with different ordering it's easier to parse: tuir supports color schemes, mailcap for opening media links, user login and persistent authentication; all with extensive examples and documentation. ----- End forwarded message -----
