On Sun Jan 12, 2020 at 02:30:00PM +0000, Stuart Henderson wrote:
> Is the debug flavour the same thing as debug packages? Often these enable
> extra checks or logging.
Thanks Stuart,
Good point, after grep(1)ing a little bit in the source, it looks like
"--enable-debug" only set the compile flags.
>
> --
> Sent from a phone, apologies for poor formatting.
>
> On 12 January 2020 12:21:31 Rafael Sadowski <raf...@sizeofvoid.org> wrote:
>
> > espie pointed out two improvements/tweaks in net/litecoin, thanks espie.
> >
> > - Remove debug FLAVOR, this is no longer necessary and we do not need a
> > debug FLAVOR/Package.
> > - Add missing FLAVOR description.
> > - Enable no_x11 package build.
> >
> > OK?
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/net/Makefile,v
> > retrieving revision 1.1163
> > diff -u -p -r1.1163 Makefile
> > --- Makefile 10 Jan 2020 17:37:35 -0000 1.1163
> > +++ Makefile 12 Jan 2020 11:43:44 -0000
> > @@ -225,7 +225,7 @@
> > SUBDIR += libupnp
> > SUBDIR += libupnpp
> > SUBDIR += libvncserver
> > - SUBDIR += litecoin
> > + SUBDIR += litecoin,no_x11
> > SUBDIR += livemedia
> > SUBDIR += lldpd
> > SUBDIR += lldpd,snmp
> > Index: litecoin/Makefile
> > ===================================================================
> > RCS file: /cvs/ports/net/litecoin/Makefile,v
> > retrieving revision 1.8
> > diff -u -p -r1.8 Makefile
> > --- litecoin/Makefile 2 Jan 2020 14:27:46 -0000 1.8
> > +++ litecoin/Makefile 12 Jan 2020 11:43:44 -0000
> > @@ -7,7 +7,7 @@ COMMENT = P2P payment system
> > GH_ACCOUNT = litecoin-project
> > GH_PROJECT = litecoin
> > GH_TAGNAME = v0.17.1
> > -REVISION = 2
> > +REVISION = 3
> >
> > SHARED_LIBS += bitcoinconsensus 1.0 # 0.0
> > SHARED_LIBS += secp256k1 0.0 # 0.0
> > @@ -52,12 +52,8 @@ CXXFLAGS += -std=c++11
> >
> > MAKE_FLAGS = CC="${CC}" CXX="${CXX}" CFLAGS="${CFLAGS}"
> > CXXFLAGS="${CXXFLAGS}"
> >
> > -FLAVORS = no_x11 debug
> > +FLAVORS = no_x11
> > FLAVOR ?=
> > -
> > -.if ${FLAVOR:Mdebug}
> > -CONFIGURE_ARGS += --enable-debug
> > -.endif
> >
> > .if ${FLAVOR:Mno_x11}
> > CONFIGURE_ARGS += --without-gui
> > Index: litecoin/pkg/DESCR
> > ===================================================================
> > RCS file: /cvs/ports/net/litecoin/pkg/DESCR,v
> > retrieving revision 1.1.1.1
> > diff -u -p -r1.1.1.1 DESCR
> > --- litecoin/pkg/DESCR 8 Mar 2019 05:52:25 -0000 1.1.1.1
> > +++ litecoin/pkg/DESCR 12 Jan 2020 11:43:44 -0000
> > @@ -11,3 +11,7 @@ the same time, on the same hardware used
> > specialized ASICs for Bitcoin, Litecoin continues to satisfy these goals.
> > It is
> > unlikely for ASIC mining to be developed for Litecoin until the currency is
> > widely used.
> > +
> > +Available flavors:
> > +
> > + no_x11: Built daemon and CLI tools only, no Qt5 GUI tools
> > Index: litecoin/pkg/PLIST
> > ===================================================================
> > RCS file: /cvs/ports/net/litecoin/pkg/PLIST,v
> > retrieving revision 1.1.1.1
> > diff -u -p -r1.1.1.1 PLIST
> > --- litecoin/pkg/PLIST 8 Mar 2019 05:52:25 -0000 1.1.1.1
> > +++ litecoin/pkg/PLIST 12 Jan 2020 11:43:44 -0000
> > @@ -20,13 +20,13 @@ include/bitcoinconsensus.h
> > include/secp256k1.h
> > include/secp256k1_recovery.h
> > include/univalue.h
> > -lib/libbitcoinconsensus.a
> > +@static-lib lib/libbitcoinconsensus.a
> > lib/libbitcoinconsensus.la
> > @lib lib/libbitcoinconsensus.so.${LIBbitcoinconsensus_VERSION}
> > -lib/libsecp256k1.a
> > +@static-lib lib/libsecp256k1.a
> > lib/libsecp256k1.la
> > @lib lib/libsecp256k1.so.${LIBsecp256k1_VERSION}
> > -lib/libunivalue.a
> > +@static-lib lib/libunivalue.a
> > lib/libunivalue.la
> > @lib lib/libunivalue.so.${LIBunivalue_VERSION}
> > lib/pkgconfig/libbitcoinconsensus.pc
>
>
>
