On Wed, Dec 25, 2019 at 12:31:59PM +0100, Jeremie Courreges-Anglas wrote: > On Wed, Dec 25 2019, Tom Murphy <open...@pertho.net> wrote: > > Hi Ingo & ports@, > > > > This is my first stab at redoing x11/lemonfonts into a SUBPACKAGE > > port. I've taken x11/lemonbar and added a -xft SUBPACKAGE that can > > do the nicer fonts. > > This doesn't really look like a SUBPACKAGE port. SUBPACKAGES are what > you use within *one* port to provide multiple subparts with varying > dependencies (eg a -postgresql subpackage that provides additional > support for postgres) or purpose (eg a -server subpackage). See > MULTI_PACKAGES in ports(7). > > With your current proposal I see no reason to move the regular port > under "base" and the fork under "xft", since they don't share anything > using an x11/lemonbar/Makefile.inc file. > > I fear I'm missing the whole picture, but as is this looks like > a candidate for a new port called x11/lemonbar-xft or whatever, with > proper @conflict markers added to the PLIST of both affected ports. > > Skimming through the proposal, the "xft" port has a patch to use pledge. > 1. it's better to note this using a # uses pledge() marker before WANTLIB > 2. a pledge(2) failure should be fatal > > -- > jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
Hi, Yeah that's a good point. OK just ignore said subpackage. I have compiled and installed Ingo's port from: https://marc.info/?l=openbsd-ports&m=155042965323231&w=2 And it compiles, installs and runs fine for me as 'lemonbar-xft' (which is differentiated from 'lemonbar' from the original x11/lemonbar port) (I had to just change PERMIT_PACKAGE_CDROM to PERMIT_PACKAGE in the Makefile) Thanks, Tom
