On 2019/12/29 16:35, Denis Fondras wrote:
> On Sun, Dec 29, 2019 at 01:28:24PM +0100, Stephane Guedon wrote:
> > You will find here an update for my port for libvips. It is, among other
> > things, a dependency to PeerTube.
> >
> > I welcome any comment on the port as I am learning it. I am still ok to
> > be the maintainer or to let it to a person of more skills than me. :)
> >
>
> Thank you Stephane.
>
> You missed step 17 of
> https://www.openbsd.org/faq/ports/guide.html#PortsChecklist.
> You can also add yourself as MAINTAINER.
>
> You can check with /usr/ports/infrastructure/bin/portcheck.
>
> I am not a port expert but these lines look wrong :
> SHARED_LIBS += vips 0.1 # 53.1
> SHARED_LIBS += vips-cpp 0.1 # 53.1
yep, please start at 0.0, also please split LIB_DEPENDS out to one-per-line i.e.
LIB_DEPENDS = devel/glib2 \
graphics/png \
[...]
>
> Apart from this, it works great on amd64. I am OK to import when these are
> fixed.
>
