On Sat, Dec 28, 2019 at 01:32:05PM +0000, Stuart Henderson wrote: > > > What's the reason for the gnu libtool use? I'd like to see a comment > > > next to the line in the cases where it's unavoidable. > > > > I used GNU libtool because libspiro fails to build otherwise: > > > > cc: error: unsupported option '--mode=link' > > Error while executing cc -shared -fPIC -DPIC -o .libs/libspiro.so.0.0 -Wall > > -Wextra -Wcast-align -Wbad-function-cast -Wc++-compat -Wmissing-prototypes > > -Wunused -O2 -pipe -Wall -Wextra -Wcast-align -Wbad-function-cast > > -Wc++-compat -Wmissing-prototypes -Wunused --mode=link .libs/spiro.o > > .libs/bezctx.o .libs/spiroentrypoints.o -L.libs -lm > > -Wl,-soname,libspiro.so.0.0 > > > > If this is a valid reason, I will add a comment. If not please point me > > in the right direction :) > > > > I think that is OK with a comment. If/when somebody has time to work on > base libtool they can easily search the ports tree for these and get some > idea from the comment what the problem might be - and requiring the comment > helps discourage others from just using USE_LIBTOOL=gnu when all that's > needed is the m4 files :-)
Thanks, that makes sense. I added the comment in my tree, so it will be there when I submit an updated tarball for this port. I have reported the two different issues exposed by the test suite, and upstream has been receptive and is working on fixing both.
