Revised patch to add devel/p5-Types-Tiny as RUN_DEPENDS and add
devel/p5-Test-NoTabs as TEST_DEPENDS.

There are some XS "recommends" such as URL::Encode::XS,CGI::Deurl::XS
and HTTP::XSCookies. But they had not been imported into OpenBSD portstree,
I shall do that later.

Regards,
wen
________________________________
发件人: Andrew Hewus Fresh <and...@afresh1.com>
发送时间: 2019年11月24日 7:41
收件人: wen heping <wenheping2...@hotmail.com>
抄送: ports@openbsd.org <ports@openbsd.org>
主题: Re: [Update] www/p5-Dancer2 : Updae to 0.208001

On Wed, Nov 06, 2019 at 08:07:43AM +0000, wen heping wrote:
> Hi, ports@:
>
>   Here is a patch for www/p5-Dancer2:
>    i) Update to 0.208001
>    ii) Update and sort RUN_DEPENDS
>    iii) Remove BUILD_DEPENDS=${RUN_DEPENDS} line
>    vi) ADD TEST_POD=yes to MAKE_ENV
>
>   It build well and run well and pass all tests on amd64-current system.
>
>   4 ports depends on it, all build well and pass all tests.(1 port should 
> update first):
>       www/p5-Dancer2-Plugin-Ajax
>       www/p5-Dancer2-Plugin-Database
>      www/p5-Dancer2-Plugin-DBIC
>      www/p5-Dancer2-Plugin-Auth-Tiny
>
> Comments? OK?
> wen

Missing a RUN_DEPENDS on devel/p5-Types-Tiny and a TEST_DEPENDS on
devel/p5-Test-NoTabs.  There are also some XS "recommends" that if
someone actually wanted to use this "in production" I would recommend
they port them and add as RUN_DEPENDS.  (They're listed as "Runtime
Recommends" when running "make test")

But, with those two missing dependencies fixed, OK afresh1@


> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/www/p5-Dancer2/Makefile,v
> retrieving revision 1.8
> diff -u -p -r1.8 Makefile
> --- Makefile  12 Jul 2019 20:50:52 -0000      1.8
> +++ Makefile  6 Nov 2019 07:17:10 -0000
> @@ -4,20 +4,19 @@ COMMENT =           lightweight yet powerful web
>
>  MODULES =            cpan
>  PKG_ARCH =           *
> -DISTNAME =           Dancer2-0.166001
> +DISTNAME =           Dancer2-0.208001
>  CATEGORIES =         www
> -REVISION =           0
>
>  # Perl
>  PERMIT_PACKAGE =     Yes
>
> -BUILD_DEPENDS =              devel/p5-File-ShareDir-Install>=0.06 \
> -                     ${RUN_DEPENDS}
> +BUILD_DEPENDS =              devel/p5-File-ShareDir-Install>=0.06
>
>  RUN_DEPENDS =                 devel/p5-App-Cmd \
>                        devel/p5-Class-Load \
>                        devel/p5-Config-Any \
>                        security/p5-Digest-SHA1 \
> +                     devel/p5-File-Share \
>                        www/p5-HTTP-Body \
>                        www/p5-HTTP-Cookies \
>                        www/p5-HTTP-Date \
> @@ -25,30 +24,28 @@ RUN_DEPENDS =              devel/p5-App-Cmd \
>                        devel/p5-Hash-Merge-Simple \
>                        devel/p5-Import-Into \
>                        converters/p5-JSON \
> +                     converters/p5-JSON-XS \
>                        mail/p5-MIME-Types \
>                        devel/p5-Moo>=2.000000 \
>                        devel/p5-MooX-Types-MooseLike \
> -                     www/p5-Plack>=1.0035 \
> +                     www/p5-Plack>=1.0040 \
>                        www/p5-Plack-Middleware-FixMissingBodyInRedirect \
>                        www/p5-Plack-Middleware-RemoveRedundantBody \
> +                     devel/p5-Ref-Util \
>                        devel/p5-Return-MultiLevel \
>                        devel/p5-Safe-Isa \
> +                     devel/p5-Scope-Upper \
>                        textproc/p5-Template \
>                        textproc/p5-Template-Tiny \
> -                     devel/p5-YAML \
> -                     converters/p5-JSON-XS \
> -                     devel/p5-Class-Load-XS \
> -                     devel/p5-Scope-Upper
> +                     devel/p5-YAML
>
>  TEST_DEPENDS =               devel/p5-AnyEvent \
> -                     sysutils/p5-Capture-Tiny \
> -                     www/p5-HTTP-Body \
> -                     www/p5-HTTP-Cookies \
> -                     www/p5-HTTP-Message \
> -                     www/p5-Plack>=1.0035 \
> +                     devel/p5-Test-EOL \
>                        devel/p5-Test-Fatal \
>                        devel/p5-Test-Memory-Cycle>=1.04 \
>                        devel/p5-Test-MockTime \
> -                     devel/p5-YAML
> +                     devel/p5-Test-Perl-Critic
> +
> +MAKE_ENV +=          TEST_POD=yes AUTHOR_TESTING=Yes
>
>  .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/www/p5-Dancer2/distinfo,v
> retrieving revision 1.4
> diff -u -p -r1.4 distinfo
> --- distinfo  24 Jan 2016 10:51:58 -0000      1.4
> +++ distinfo  6 Nov 2019 07:17:10 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (Dancer2-0.166001.tar.gz) = 
> Bsec08x9k2d5D7cyA3eMJIQMO2WGJu5C51R4plNGlaQ=
> -SIZE (Dancer2-0.166001.tar.gz) = 324270
> +SHA256 (Dancer2-0.208001.tar.gz) = 
> A4YaSNTmU3+Yx56rLbilkerK7+8FwITwg7O4dmYOH+w=
> +SIZE (Dancer2-0.208001.tar.gz) = 381526
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/www/p5-Dancer2/pkg/PLIST,v
> retrieving revision 1.3
> diff -u -p -r1.3 PLIST
> --- pkg/PLIST 22 Jan 2016 08:55:34 -0000      1.3
> +++ pkg/PLIST 6 Nov 2019 07:17:10 -0000
> @@ -82,9 +82,6 @@ ${P5SITE}/Dancer2/Template/TemplateToolk
>  ${P5SITE}/Dancer2/Template/Tiny.pm
>  ${P5SITE}/Dancer2/Test.pm
>  ${P5SITE}/Dancer2/Tutorial.pod
> -${P5SITE}/auto/
> -${P5SITE}/auto/share/
> -${P5SITE}/auto/share/dist/
>  ${P5SITE}/auto/share/dist/Dancer2/
>  ${P5SITE}/auto/share/dist/Dancer2/skel/
>  ${P5SITE}/auto/share/dist/Dancer2/skel/.dancer


--
andrew - http://afresh1.com

Real programmers don't document.
          If it was hard to write, it should be hard to understand.
Index: Makefile
===================================================================
RCS file: /cvs/ports/www/p5-Dancer2/Makefile,v
retrieving revision 1.8
diff -u -p -r1.8 Makefile
--- Makefile    12 Jul 2019 20:50:52 -0000      1.8
+++ Makefile    26 Nov 2019 02:42:20 -0000
@@ -4,20 +4,19 @@ COMMENT =             lightweight yet powerful web 
 
 MODULES =              cpan
 PKG_ARCH =             *
-DISTNAME =             Dancer2-0.166001
+DISTNAME =             Dancer2-0.208001
 CATEGORIES =           www
-REVISION =             0
 
 # Perl
 PERMIT_PACKAGE =       Yes
 
-BUILD_DEPENDS =                devel/p5-File-ShareDir-Install>=0.06 \
-                       ${RUN_DEPENDS}
+BUILD_DEPENDS =                devel/p5-File-ShareDir-Install>=0.06
 
 RUN_DEPENDS =          devel/p5-App-Cmd \
                        devel/p5-Class-Load \
                        devel/p5-Config-Any \
                        security/p5-Digest-SHA1 \
+                       devel/p5-File-Share \
                        www/p5-HTTP-Body \
                        www/p5-HTTP-Cookies \
                        www/p5-HTTP-Date \
@@ -25,30 +24,30 @@ RUN_DEPENDS =               devel/p5-App-Cmd \
                        devel/p5-Hash-Merge-Simple \
                        devel/p5-Import-Into \
                        converters/p5-JSON \
+                       converters/p5-JSON-XS \
                        mail/p5-MIME-Types \
                        devel/p5-Moo>=2.000000 \
                        devel/p5-MooX-Types-MooseLike \
-                       www/p5-Plack>=1.0035 \
+                       www/p5-Plack>=1.0040 \
                        www/p5-Plack-Middleware-FixMissingBodyInRedirect \
                        www/p5-Plack-Middleware-RemoveRedundantBody \
+                       devel/p5-Ref-Util \
                        devel/p5-Return-MultiLevel \
                        devel/p5-Safe-Isa \
+                       devel/p5-Scope-Upper \
                        textproc/p5-Template \
                        textproc/p5-Template-Tiny \
-                       devel/p5-YAML \
-                       converters/p5-JSON-XS \
-                       devel/p5-Class-Load-XS \
-                       devel/p5-Scope-Upper
+                       devel/p5-Type-Tiny \
+                       devel/p5-YAML
 
 TEST_DEPENDS =         devel/p5-AnyEvent \
-                       sysutils/p5-Capture-Tiny \
-                       www/p5-HTTP-Body \
-                       www/p5-HTTP-Cookies \
-                       www/p5-HTTP-Message \
-                       www/p5-Plack>=1.0035 \
+                       devel/p5-Test-EOL \
                        devel/p5-Test-Fatal \
                        devel/p5-Test-Memory-Cycle>=1.04 \
                        devel/p5-Test-MockTime \
-                       devel/p5-YAML
+                       devel/p5-Test-NoTabs \
+                       devel/p5-Test-Perl-Critic
+
+MAKE_ENV +=            TEST_POD=yes AUTHOR_TESTING=Yes
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/www/p5-Dancer2/distinfo,v
retrieving revision 1.4
diff -u -p -r1.4 distinfo
--- distinfo    24 Jan 2016 10:51:58 -0000      1.4
+++ distinfo    26 Nov 2019 02:42:20 -0000
@@ -1,2 +1,2 @@
-SHA256 (Dancer2-0.166001.tar.gz) = Bsec08x9k2d5D7cyA3eMJIQMO2WGJu5C51R4plNGlaQ=
-SIZE (Dancer2-0.166001.tar.gz) = 324270
+SHA256 (Dancer2-0.208001.tar.gz) = A4YaSNTmU3+Yx56rLbilkerK7+8FwITwg7O4dmYOH+w=
+SIZE (Dancer2-0.208001.tar.gz) = 381526
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/www/p5-Dancer2/pkg/PLIST,v
retrieving revision 1.3
diff -u -p -r1.3 PLIST
--- pkg/PLIST   22 Jan 2016 08:55:34 -0000      1.3
+++ pkg/PLIST   26 Nov 2019 02:42:20 -0000
@@ -82,9 +82,6 @@ ${P5SITE}/Dancer2/Template/TemplateToolk
 ${P5SITE}/Dancer2/Template/Tiny.pm
 ${P5SITE}/Dancer2/Test.pm
 ${P5SITE}/Dancer2/Tutorial.pod
-${P5SITE}/auto/
-${P5SITE}/auto/share/
-${P5SITE}/auto/share/dist/
 ${P5SITE}/auto/share/dist/Dancer2/
 ${P5SITE}/auto/share/dist/Dancer2/skel/
 ${P5SITE}/auto/share/dist/Dancer2/skel/.dancer

Reply via email to