On 11/22/19 8:59 AM, Marc Espie wrote:
> On Fri, Nov 22, 2019 at 08:47:24AM -0500, Kurt Mosiejczuk wrote:
>> On Thu, Nov 21, 2019 at 05:13:50PM -0500, George Rosamond wrote:
>>
>>> On 11/21/19 2:25 PM, Jeremy Evans wrote:
>>
>>>> Can you please resubmit without the gratuitous style changes ("VAR=" to
>>>> "VAR =")?
>>
>>> Corrected and attached.
>>
>>> I assumed the style change was appropriate since it matches
>>> /usr/ports/infrastructure/templates/Makefile.template.
>>
>> For new ports you are correct. Generally we want to match the existing
>> style of the port. That way the diff doesn't look like one is changing
>> everything at once.
>
> When I do sweep, my automated tools DO add variables with a " =".
>
> In which case I don't give a flying fuck about the existing port's style.
>
>
> To reiterate: our make recognizes +=, !=, ?= as being special.
>
> Some ports have subpackages name that end in c++, for instance.
> That leads to indexed variables that end in c++, and then the space
> is mandatory.
>
> In the end, it was just simpler to always put spaces in *any*
> variable assignment in infrastructure.
>
> After a few years of that, my brain is 100% wired to expect the space.
>
Thanks. I strongly appreciate and respect the OpenBSD coding style
guide, particularly when having to deal with other port systems which
look like chaos.
g
