Hi Rafael,
On Sat, Nov 16, 2019 at 01:03:05PM +0100, Rafael Sadowski wrote:
> -DCMAKE_SKIP_INSTALL_ALL_DEPENDENCY=ON \
Yeah, looks like I missed that. If it works, we can add it.
> -G ${_MODCMAKE_GEN}
It would be nice if this one worked, but to use it properly, we'd also
have to invoke ${MODCMAKE_BUILD_TARGET} (instead of hard-coding make or
ninja). Sadly the target does a `cd ${WRKBUILD}` which isn't right for
us.
So I guess it's better to hard-code make or ninja. My diff used make.
> ${CONFIGURE_ARGS} \
This one breaks the cmake configure, as we end up passing neovim
configure args to luv's configure.
> exec ${SETENV} ${MAKE_ENV} ${FAKE_SETUP} ${NINJA} ${NINJA_FLAGS} install
Right, so hard-coding ninja. I don't mind which (make or ninja) we use.
Thanks!
--
Best Regards
Edd Barrett
http://www.theunixzoo.co.uk
