On Fri, Nov 08 2019, Charlene Wendling <[email protected]> wrote: >> http://build-failures.rhaalovely.net/sparc64/2019-11-07/security/opensc.log > > The glib2 update brought some deprecations, and as such uncovered more > ports that are built with `-Werror'. > > I simply removed it, and then it builds [0] on macppc. > > Comments/feedback are welcome!
-Werror considered harmful, ok jca@ > > Charlène. > > > [0] https://bin.charlenew.xyz/opensc.log > > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/security/opensc/Makefile,v > retrieving revision 1.52 > diff -u -p -u -p -r1.52 Makefile > --- Makefile 12 Jul 2019 20:49:05 -0000 1.52 > +++ Makefile 8 Nov 2019 21:36:58 -0000 > @@ -3,7 +3,7 @@ > COMMENT= set of libraries and utilities to access smart cards > > V= 0.19.0 > -REVISION= 2 > +REVISION= 3 > DISTNAME= opensc-${V} > SUBST_VARS += V > > Index: patches/patch-configure_ac > =================================================================== > RCS file: /cvs/ports/security/opensc/patches/patch-configure_ac,v > retrieving revision 1.8 > diff -u -p -u -p -r1.8 patch-configure_ac > --- patches/patch-configure_ac 29 Sep 2018 11:19:16 -0000 1.8 > +++ patches/patch-configure_ac 8 Nov 2019 21:36:58 -0000 > @@ -4,6 +4,8 @@ Fix version string > > libdl is not required on OpenBSD > > +Remove -Werror so it builds with gcc > + > Index: configure.ac > --- configure.ac.orig > +++ configure.ac > @@ -51,7 +53,7 @@ Index: configure.ac > dnl Special check for pthread support. > AX_PTHREAD( > [AC_DEFINE( > -@@ -1036,7 +1011,6 @@ AM_CONDITIONAL([ENABLE_SM], [test "${enable_sm}" = "ye > +@@ -1036,14 +1011,13 @@ AM_CONDITIONAL([ENABLE_SM], [test "${enable_sm}" = > "ye > AM_CONDITIONAL([ENABLE_DNIE_UI], [test "${enable_dnie_ui}" = "yes"]) > AM_CONDITIONAL([ENABLE_NPATOOL], [test "${ENABLE_NPATOOL}" = "yes"]) > AM_CONDITIONAL([ENABLE_TESTS], [test "${enable_tests}" = "yes"]) > @@ -59,3 +61,11 @@ Index: configure.ac > > if test "${enable_pedantic}" = "yes"; then > enable_strict="yes"; > + CFLAGS="${CFLAGS} -pedantic" > + fi > + if test "${enable_strict}" = "yes"; then > +- CFLAGS="${CFLAGS} -Wall -Wextra -Wno-unused-parameter -Werror" > ++ CFLAGS="${CFLAGS} -Wall -Wextra -Wno-unused-parameter" > + fi > + > + AC_CONFIG_FILES([ > -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
