On Thu, 24 Oct 2019 14:28:53 +0000 wen heping wrote: > Would any committer have a look of this patch? > It block many other updates. > wen > ________________________________ > 发件人: owner-po...@openbsd.org <owner-po...@openbsd.org> 代表 wen > heping <wenheping2...@hotmail.com> 发送时间: 2019年10月17日 10:09 > 收件人: Abel Abraham Camarillo Ojeda <acam...@verlet.org>; > afre...@openbsd.org <afre...@openbsd.org> 抄送: ports@openbsd.org > <ports@openbsd.org> 主题: 回复: [Update] www/p5-Plack : Update to > 1.0047 > > Revised patch, include updated RUN_DEPENDS, updated COMMENT and DESCR. > > wen > ________________________________ > 发件人: Andrew Hewus Fresh <and...@afresh1.com> > 发送时间: 2019年9月19日 9:46 > 收件人: Abel Abraham Camarillo Ojeda <acam...@verlet.org> > 抄送: wen heping <wenheping2...@hotmail.com>; ports@openbsd.org > <ports@openbsd.org> 主题: Re: [Update] www/p5-Plack : Update to 1.0047 > > On Thu, Aug 29, 2019 at 11:44:10AM -0500, Abel Abraham Camarillo > Ojeda wrote: > > On Thursday, August 29, 2019, wen heping > > <wenheping2...@hotmail.com> wrote: > > > > > Hi, > > > > > > Here is a patch for www/p5-Plack: > > > i) Update to 1.0047 > > > ii) Update RUN_DEPENDS > > > > > > It build well and passed all tests on amd64-head system. > > > > > > 15 ports depends on p5-Plack, 13 build well and passed > > > regression tests. www/p5-Catalyst-Runtime and www/p5-Dancer2 had > > > 2 or 3 tests failed, but it was not caused by the update of > > > p5-Plack. > > > > > > Comments? OK? > > > > > > > OK maintainer > > I noticed the Changelog said something about no longer needing > HTTP::Body, but that it wasn't removed from RUN_DEPENDS, so I re-ran > portgen(1) and it went away. Plus a couple other small updates. > > Not sure if the DESCR or COMMENT updates are desired, but since > portgen suggested it, I left it in. > > (I also noticed this pulls in 1.0046 which is the patch I got > upstreamed at work to add psgix.cleanup support, yay!) > > And last, I noticed that www/p5-FCGI needs FIX_EXTRACT_PERMISSIONS, so > if someone feels like looking at that. I might get around to it > eventually, or if someone just reminds me if that needs a REVISION, > I'll just commit it.
The diff is fine, i've retested direct consumers, it is still as Wen reported it. More tests could be run though, with what we've already in ports. As such, this is the same diff seen previously, just with more TEST_DEPENDS. With or without them, OK cwen@ [0] https://bin.charlenew.xyz/p5-Plack.tgz Index: Makefile =================================================================== RCS file: /cvs/ports/www/p5-Plack/Makefile,v retrieving revision 1.11 diff -u -p -u -p -r1.11 Makefile --- Makefile 12 Jul 2019 20:50:57 -0000 1.11 +++ Makefile 26 Oct 2019 22:27:51 -0000 @@ -1,10 +1,10 @@ # $OpenBSD: Makefile,v 1.11 2019/07/12 20:50:57 sthen Exp $ -COMMENT = interface between perl web frameworks and web servers +COMMENT = perl superglue for web frameworks and web servers MODULES = cpan PKG_ARCH = * -DISTNAME = Plack-1.0039 +DISTNAME = Plack-1.0047 CATEGORIES = www MAINTAINER = Abel Abraham Camarillo Ojeda <acam...@verlet.org> @@ -15,18 +15,19 @@ BUILD_DEPENDS = devel/p5-File-ShareDir-I RUN_DEPENDS = devel/p5-Devel-StackTrace>=1.23 \ devel/p5-Devel-StackTrace-AsHTML>=0.11 \ - devel/p5-File-ShareDir>=1.00 \ + devel/p5-File-ShareDir>=1.0 \ devel/p5-Hash-MultiValue>=0.05 \ devel/p5-Stream-Buffered>=0.02 \ - devel/p5-Try-Tiny>=0 \ - net/p5-Test-TCP>=2.00 \ - sysutils/p5-Filesys-Notify-Simple>=0 \ - www/p5-Apache-LogFormat-Compiler>=0.12 \ - www/p5-Cookie-Baker>=0.05 \ - www/p5-HTTP-Body>=1.06 \ + devel/p5-Try-Tiny \ + net/p5-Test-TCP>=2.15 \ + sysutils/p5-Filesys-Notify-Simple \ + www/p5-Apache-LogFormat-Compiler>=0.33 \ + www/p5-Cookie-Baker>=0.07 \ + www/p5-HTTP-Entity-Parser>=0.17 \ www/p5-HTTP-Headers-Fast>=0.18 \ www/p5-HTTP-Message>=5.814 \ - www/p5-URI>=1.59 + www/p5-URI>=1.59 \ + www/p5-WWW-Form-UrlEncoded>=0.23 # Not required, but make it more useful RUN_DEPENDS += www/fcgi \ @@ -34,6 +35,13 @@ RUN_DEPENDS += www/fcgi \ www/p5-CGI-Compile \ www/p5-FCGI-ProcManager -TEST_DEPENDS = devel/p5-Test-Requires>=0 +TEST_DEPENDS = devel/p5-Log-Dispatch>=2.25 \ + devel/p5-Log-Log4perl \ + devel/p5-Module-Refresh \ + devel/p5-Test-Requires \ + mail/p5-MIME-Types \ + www/p5-CGI \ + www/p5-CGI-Emulate-PSGI \ + www/p5-HTTP-Request-AsCGI .include <bsd.port.mk> Index: distinfo =================================================================== RCS file: /cvs/ports/www/p5-Plack/distinfo,v retrieving revision 1.5 diff -u -p -u -p -r1.5 distinfo --- distinfo 18 Jan 2016 22:48:06 -0000 1.5 +++ distinfo 26 Oct 2019 22:27:51 -0000 @@ -1,2 +1,2 @@ -SHA256 (Plack-1.0039.tar.gz) = 0kpXLohkTH05x+b/GvAFtyjeyUqHjPBtkCerfRov0Kk= -SIZE (Plack-1.0039.tar.gz) = 176711 +SHA256 (Plack-1.0047.tar.gz) = MiyT9azAoPDhH9SnYYj5eL3BQzip8d865TUicBcEZWE= +SIZE (Plack-1.0047.tar.gz) = 180792 Index: pkg/DESCR =================================================================== RCS file: /cvs/ports/www/p5-Plack/pkg/DESCR,v retrieving revision 1.1.1.1 diff -u -p -u -p -r1.1.1.1 DESCR --- pkg/DESCR 11 Dec 2010 09:51:31 -0000 1.1.1.1 +++ pkg/DESCR 26 Oct 2019 22:27:51 -0000 @@ -1,6 +1,4 @@ -Plack is a set of tools for using the PSGI stack. It contains middleware -components, a reference server and utilities for Web application -frameworks. Plack is like Ruby's Rack or Python's Paste for WSGI. - -See PSGI for the PSGI specification and PSGI::FAQ to know what PSGI and -Plack are and why we need them. +Plack is a set of tools for using the PSGI stack. It contains +middleware components, a reference server and utilities for Web +application frameworks. Plack is like Ruby's Rack or Python's +Paste for WSGI. Index: pkg/PLIST =================================================================== RCS file: /cvs/ports/www/p5-Plack/pkg/PLIST,v retrieving revision 1.4 diff -u -p -u -p -r1.4 PLIST --- pkg/PLIST 18 Jan 2016 22:48:06 -0000 1.4 +++ pkg/PLIST 26 Oct 2019 22:27:51 -0000 @@ -1,6 +1,5 @@ @comment $OpenBSD: PLIST,v 1.4 2016/01/18 22:48:06 nigel Exp $ bin/plackup -${P5SITE}/HTTP/ ${P5SITE}/HTTP/Message/ ${P5SITE}/HTTP/Message/PSGI.pm ${P5SITE}/HTTP/Server/ @@ -87,11 +86,7 @@ ${P5SITE}/Plack/Test/Suite.pm ${P5SITE}/Plack/Util/ ${P5SITE}/Plack/Util.pm ${P5SITE}/Plack/Util/Accessor.pm -${P5SITE}/auto/ -${P5SITE}/auto/share/ -${P5SITE}/auto/share/dist/ ${P5SITE}/auto/share/dist/Plack/ -${P5SITE}/auto/share/dist/Plack/#foo ${P5SITE}/auto/share/dist/Plack/baybridge.jpg ${P5SITE}/auto/share/dist/Plack/face.jpg @man man/man1/plackup.1
