On Sat, Oct 26, 2019 at 01:43:20PM +0200, Rafael Sadowski wrote:
> On Fri Oct 25, 2019 at 09:24:34PM -0400, Brad Smith wrote:
> > Here is an update to mpv 0.30.0.
> > 
> 
> First of all, thanks for the update. Works fine here on amd64. But...
> 
> > +
> > +# seems like a waf bug, we're not tvOS -- 7087
> > +#CONFIGURE_ARGS+=  --disable-tvos
> 
> ... you missed to uncomment this line.

Ya, I was trying to figure out what the root issue was and forgot to uncomment
when making another diff.

> Otherwise OK rsadowski@

Here is another diff with some further tweaks.

Upstream figured out what was going on with the tvOS issue. I missed removing
--enable-tv since the TV backend support was removed, but the --enable-tv
option for some odd reason with WAF will match agains't the equivalent of
--enable-tvos.

The dependency tweak is because libdvdread supportt was removed.


Index: Makefile
===================================================================
RCS file: /home/cvs/ports/multimedia/mpv/Makefile,v
retrieving revision 1.52
diff -u -p -u -p -r1.52 Makefile
--- Makefile    26 Oct 2019 14:06:55 -0000      1.52
+++ Makefile    26 Oct 2019 17:21:50 -0000
@@ -5,6 +5,7 @@ COMMENT =               movie player based on MPlayer
 GH_ACCOUNT =           mpv-player
 GH_PROJECT =           mpv
 GH_TAGNAME =           v0.30.0
+REVISION =             0
 
 SHARED_LIBS +=         mpv             0.1 # 1.106
 
@@ -40,7 +41,6 @@ BUILD_DEPENDS =               audio/ladspa \
 LIB_DEPENDS =          audio/libcdio \
                        audio/libcdio-paranoia \
                        converters/libiconv \
-                       devel/libdvdread \
                        devel/sdl2 \
                        graphics/ffmpeg>=4.1.1 \
                        graphics/jpeg \
@@ -64,7 +64,6 @@ CONFIGURE_ARGS =      --confloaddir=${SYSCONF
                        --enable-libmpv-shared \
                        --enable-sndio \
                        --enable-sdl2 \
-                       --enable-tv \
                        --disable-alsa \
                        --disable-caca \
                        --disable-cuda-hwaccel \
@@ -91,9 +90,6 @@ CONFIGURE_ARGS =      --confloaddir=${SYSCONF
                        --disable-videotoolbox-gl \
                        --disable-vulkan \
                        --disable-wayland
-
-# seems like a waf bug, we're not tvOS -- 7087
-CONFIGURE_ARGS +=      --disable-tvos
 
 MAKE_ENV +=            LDFLAGS="-L${LOCALBASE}/lib -L${X11BASE}/lib"
 MAKE_ENV +=            CPPFLAGS="-I${LOCALBASE}/include -I${X11BASE}/include"

Reply via email to