On Thu, 26 Sep 2019 11:51:20 +0000 wen heping wrote: > Hi, ports@: > > Here is a patch for devel/p5-System-Command: > i) Update to 1.119 > ii) Add AUTHOR_TESTING=yes to MKAE_ENV, then it could > run pod tests. > iii) Remove CONFIGURE_STYLE = modbuild > > It build well and passed all tests on amd64-head system. It > was required by update of devel/p5-Git-Repository. > One port depends on it :p5-Git-Repository. > > Comments? OK?
It requires devel/p5-IPC-Run as a RUN_DEPENDS. devel/p5-Test-Command is also needed as a TEST_DEPENDS so all tests run, see the META.json file [0]. Pod testing requires Pod::Coverage::TrustPod that we don't have in ports, so we're better off disabling it. Fixed diff below :) Charlène. [0] https://metacpan.org/source/BOOK/System-Command-1.119/META.json Index: Makefile =================================================================== RCS file: /cvs/ports/devel/p5-System-Command/Makefile,v retrieving revision 1.6 diff -u -p -u -p -r1.6 Makefile --- Makefile 12 Jul 2019 20:45:07 -0000 1.6 +++ Makefile 17 Oct 2019 08:36:22 -0000 @@ -4,18 +4,18 @@ COMMENT = object for running system com MODULES = cpan PKG_ARCH = * -DISTNAME = System-Command-1.07 +DISTNAME = System-Command-1.119 CATEGORIES = devel -REVISION = 0 - # perl PERMIT_PACKAGE = Yes -CONFIGURE_STYLE = modbuild +RUN_DEPENDS = devel/p5-IPC-Run -MAKE_ENV += TEST_POD=yes +TEST_DEPENDS = devel/p5-Test-Command \ + devel/p5-Test-Output -TEST_DEPENDS = devel/p5-Test-Output +# Requires Pod::Coverage::TrustPod that we don't have in ports +MAKE_ENV += TEST_POD= AUTHOR_TESTING= .include <bsd.port.mk> Index: distinfo =================================================================== RCS file: /cvs/ports/devel/p5-System-Command/distinfo,v retrieving revision 1.3 diff -u -p -u -p -r1.3 distinfo --- distinfo 1 May 2014 06:59:28 -0000 1.3 +++ distinfo 17 Oct 2019 08:36:22 -0000 @@ -1,2 +1,2 @@ -SHA256 (System-Command-1.07.tar.gz) = hDKsJCHQMOeU5c0IE3V54/VQ0sQw2Clu7s1v0E6uxWA= -SIZE (System-Command-1.07.tar.gz) = 13261 +SHA256 (System-Command-1.119.tar.gz) = yMn7HlJ8UkY8qxR2UA7+pwOWoLYr6mJdLW+uqZTcRuc= +SIZE (System-Command-1.119.tar.gz) = 30479 Index: pkg/PLIST =================================================================== RCS file: /cvs/ports/devel/p5-System-Command/pkg/PLIST,v retrieving revision 1.1.1.1 diff -u -p -u -p -r1.1.1.1 PLIST --- pkg/PLIST 20 Jul 2011 18:04:48 -0000 1.1.1.1 +++ pkg/PLIST 17 Oct 2019 08:36:22 -0000 @@ -1,4 +1,7 @@ @comment $OpenBSD: PLIST,v 1.1.1.1 2011/07/20 18:04:48 jasper Exp $ ${P5SITE}/System/ +${P5SITE}/System/Command/ ${P5SITE}/System/Command.pm +${P5SITE}/System/Command/Reaper.pm @man man/man3p/System::Command.3p +@man man/man3p/System::Command::Reaper.3p