The additional LIB_DEPENDS for librsvg is OK (claws-mail uses it itself)
but the other new ones are only pulled in by inter library dependencies and
shouldn't be listed as LIB_DEPENDS.
--
Sent from a phone, apologies for poor formatting.
On 7 September 2019 07:43:22 Rafael Sadowski <raf...@sizeofvoid.org> wrote:
On Fri Sep 06, 2019 at 09:19:52AM -0400, Daniel Jakots wrote:
On Fri, 6 Sep 2019 15:15:25 +0200, Solene Rapenne <sol...@perso.pw>
wrote:
What is the value of a diff without any comment? I've no idea what you
looked at or if you even tested it.
I had a similar diff but I couldn't make `make lib-depends-check`
happy.
Just for fun a new diff:
- update claws-mail to 3.17.4
- switch to https
- make `make lib-depends-check` happy.
- adjust to long lines in Makefile
Just a build test with no runtime tests.
RS
Index: Makefile
===================================================================
RCS file: /cvs/ports/mail/claws-mail/Makefile,v
retrieving revision 1.121
diff -u -p -u -p -r1.121 Makefile
--- Makefile 12 Jul 2019 20:47:25 -0000 1.121
+++ Makefile 7 Sep 2019 06:35:16 -0000
@@ -6,7 +6,7 @@ COMMENT-spamassassin= spamassassin plugi
COMMENT-pdfviewer= pdfviewer plugin
COMMENT-gdata= gdata plugin
-V= 3.17.3
+V= 3.17.4
DISTNAME= claws-mail-${V}
PKGNAME-main= ${DISTNAME}
PKGNAME-bogofilter= claws-mail-bogofilter-${V}
@@ -14,18 +14,15 @@ PKGNAME-spamassassin= claws-mail-spamass
PKGNAME-pdfviewer= claws-mail-pdfviewer-${V}
PKGNAME-gdata= claws-mail-gdata-${V}
-REVISION= 0
-REVISION-pdfviewer= 1
-
CATEGORIES= mail news
-HOMEPAGE= http://www.claws-mail.org/
+HOMEPAGE= https://www.claws-mail.org/
MAINTAINER= Daniel Jakots <o...@chown.me>
# GPLv3+
PERMIT_PACKAGE= Yes
-MASTER_SITES= http://www.claws-mail.org/releases/
+MASTER_SITES= https://www.claws-mail.org/releases/
DIST_SUBDIR= claws
@@ -57,12 +54,12 @@ WANTLIB-main += croco-0.6 db dbus-1 dbus
WANTLIB-main += gpgme hogweed ical icalss icalvcal icudata icui18n icuuc idn2
WANTLIB-main += ltdl lz4 lzma nettle notify ogg p11-kit perl rsvg-2
WANTLIB-main += startup-notification-1 ${COMPILER_LIBCXX} tasn1 unistring
vorbis
-WANTLIB-main += vorbisfile xcb-util xml2 zstd
+WANTLIB-main += vorbisfile xcb-util xml2 zstd b2 charset
WANTLIB-gdata = ${WANTLIB}
WANTLIB-gdata += gck-1 gcr-base-3 gcrypt gdata goa-1.0 gpg-error json-glib-1.0
WANTLIB-gdata += lzma nspr4 nss3 oauth p11-kit plc4 plds4 smime3 nssutil3
-WANTLIB-gdata += soup-2.4 sqlite3 ssl3 xml2
+WANTLIB-gdata += soup-2.4 sqlite3 ssl3 xml2 idn2 psl unistring
WANTLIB-pdfviewer = ${WANTLIB}
WANTLIB-pdfviewer += jpeg lcms2 openjp2 png poppler poppler-glib tiff
@@ -89,7 +86,10 @@ LIB_DEPENDS-main= ${LIB_DEPENDS} \
security/libnettle \
textproc/enchant \
textproc/libical \
- x11/dbus-glib
+ textproc/libxml \
+ www/libcroco \
+ x11/dbus-glib \
+ x11/gnome/librsvg
LIB_DEPENDS-pdfviewer= ${LIB_DEPENDS} \
print/poppler
@@ -164,13 +164,17 @@ TOOLS= OOo2claws-mail.pl \
post-install:
${INSTALL_DATA_DIR} ${PREFIX}/share/icons/hicolor/48x48/apps
- ${INSTALL_DATA} ${WRKSRC}/claws-mail.png
${PREFIX}/share/icons/hicolor/48x48/apps/claws-mail.png
+ ${INSTALL_DATA} ${WRKSRC}/claws-mail.png \
+ ${PREFIX}/share/icons/hicolor/48x48/apps/claws-mail.png
${INSTALL_DATA_DIR} ${PREFIX}/share/icons/hicolor/64x64/apps
- ${INSTALL_DATA} ${WRKSRC}/claws-mail-64x64.png
${PREFIX}/share/icons/hicolor/64x64/apps/claws-mail.png
+ ${INSTALL_DATA} ${WRKSRC}/claws-mail-64x64.png \
+ ${PREFIX}/share/icons/hicolor/64x64/apps/claws-mail.png
${INSTALL_DATA_DIR} ${PREFIX}/share/icons/hicolor/128x128/apps
- ${INSTALL_DATA} ${WRKSRC}/claws-mail-128x128.png
${PREFIX}/share/icons/hicolor/128x128/apps/claws-mail.png
+ ${INSTALL_DATA} ${WRKSRC}/claws-mail-128x128.png \
+ ${PREFIX}/share/icons/hicolor/128x128/apps/claws-mail.png
${INSTALL_DATA_DIR} ${PREFIX}/share/applications/
- ${INSTALL_DATA} ${WRKSRC}/claws-mail.desktop
${PREFIX}/share/applications/claws-mail.desktop
+ ${INSTALL_DATA} ${WRKSRC}/claws-mail.desktop \
+ ${PREFIX}/share/applications/claws-mail.desktop
${INSTALL_DATA_DIR} ${PREFIX}/share/claws-mail/tools/kdeservicemenu
.for i in ${TOOLS}
${INSTALL_DATA} ${WRKSRC}/tools/${i} \
Index: distinfo
===================================================================
RCS file: /cvs/ports/mail/claws-mail/distinfo,v
retrieving revision 1.36
diff -u -p -u -p -r1.36 distinfo
--- distinfo 1 Jan 2019 18:01:20 -0000 1.36
+++ distinfo 7 Sep 2019 06:35:16 -0000
@@ -1,2 +1,2 @@
-SHA256 (claws/claws-mail-3.17.3.tar.gz) =
lQtrOFI1x0F5oHzgnFq5TeP5hpPHBkV8mLRP2QoeYKA=
-SIZE (claws/claws-mail-3.17.3.tar.gz) = 11975996
+SHA256 (claws/claws-mail-3.17.4.tar.gz) =
rbPjYadGTZOOHW8jpiQzyJh4xuABeSxcqY0izl1O+jc=
+SIZE (claws/claws-mail-3.17.4.tar.gz) = 12167751
