On Tue, Aug 27 2019, Solene Rapenne <[email protected]> wrote: > hi, this diff updates go-ipfs to 0.4.22 > > the weird thing is that `make makesum` did not update the distfile, I > had to remove it before as the distfile doesn't contain the version. > > Maybe this should be changed?
Yep, distfiles should be named uniquely (unless you use DIST_SUBDIR). The following does the trick for what we have in the tree. Maybe there's a way to remove the custom do-extract case, not sure. Index: Makefile =================================================================== RCS file: /cvs/ports/net/go-ipfs/Makefile,v retrieving revision 1.3 diff -u -p -r1.3 Makefile --- Makefile 12 Jul 2019 21:02:23 -0000 1.3 +++ Makefile 27 Aug 2019 12:51:17 -0000 @@ -3,8 +3,7 @@ COMMENT = global, versioned, peer-to-peer filesystem V = 0.4.18 -DISTNAME = go-ipfs-source -PKGNAME = go-ipfs-$V +DISTNAME = go-ipfs-$V REVISION = 0 CATEGORIES = net @@ -16,6 +15,8 @@ PERMIT_PACKAGE = Yes WANTLIB = c pthread MASTER_SITES = https://github.com/ipfs/go-ipfs/releases/download/v$V/ +DISTFILES = ${DISTNAME}{go-ipfs-source}${EXTRACT_SUFX} + MODULES = lang/go ALL_TARGET = github.com/ipfs/go-ipfs SUBST_VARS = VARBASE Index: distinfo =================================================================== RCS file: /cvs/ports/net/go-ipfs/distinfo,v retrieving revision 1.1.1.1 diff -u -p -r1.1.1.1 distinfo --- distinfo 18 Dec 2018 11:58:21 -0000 1.1.1.1 +++ distinfo 27 Aug 2019 12:51:17 -0000 @@ -1,2 +1,2 @@ -SHA256 (go-ipfs-source.tar.gz) = PcitKBhQqWxACl3NWgfcYw0OvtRvVM4AXyHrYv16DqY= -SIZE (go-ipfs-source.tar.gz) = 18790800 +SHA256 (go-ipfs-0.4.18.tar.gz) = PcitKBhQqWxACl3NWgfcYw0OvtRvVM4AXyHrYv16DqY= +SIZE (go-ipfs-0.4.18.tar.gz) = 18790800 -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
