Hi, On Sun, 11 Aug 2019 21:13:11 +0200 Jeremie Courreges-Anglas wrote:
> On Mon, Aug 05 2019, Thomas Frohwein <tfrohw...@fastmail.com> wrote: > > On Mon, Aug 05, 2019 at 12:05:05PM +0200, Jeremie Courreges-Anglas > > wrote: [...] > >> Here's a diff with proper comments which I deem desirable. > >> Charlene, Thomas, others: ok? > > > > I'd like to combine this with the update to the latest release > > (3.1.1) as previously proposed [1]. This update also does away with > > the thirdparty module that included nvcore.h, so that patch isn't > > needed anymore. > > > > The combined diff is below. I did a build and runtime test on amd64 > > and didn't notice any issues. > > > > ok for combined diff? > > I tend to prefer separating fixes and updates because it makes cvs log > clearer. Please do whatever you prefer, but I'm not volunteering to > test godot updates. I've tried the update on amd64, and it looks good to me, excepted the the extra .orig patch. I've tried several demos without issues. On macppc, i did the slightly intrusive conversion to __atomic_* successfully. It builds but doesn't link due to relocation errors - i'm working on it, but it's a long build at each try. So i can't 100% confirm how godot does with ports-gcc at the moment. I've no objection to see the update and (still needed btw) ports-gcc fixes committed, i'll provide a hppa/powerpc patch later. Charlène.
